Update bill.class.php #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
requested changes
Jun 25, 2025
Comment on lines
+228
to
+237
| $tab[] = [ | ||
| 'id' => '11', | ||
| 'table' => 'glpi_plugin_order_bills', | ||
| 'field' => 'order_name', | ||
| 'name' => __('Order ID', 'order'), | ||
| 'datatype' => 'string', | ||
| 'nosearch' => true, | ||
| 'massiveaction' => false, | ||
| 'computation' => '(SELECT num_order FROM glpi_plugin_order_orders WHERE glpi_plugin_order_orders.id = glpi_plugin_order_bills.plugin_order_orders_id)', | ||
| ]; |
There was a problem hiding this comment.
redundant search option with search option 8
Suggested change
| $tab[] = [ | |
| 'id' => '11', | |
| 'table' => 'glpi_plugin_order_bills', | |
| 'field' => 'order_name', | |
| 'name' => __('Order ID', 'order'), | |
| 'datatype' => 'string', | |
| 'nosearch' => true, | |
| 'massiveaction' => false, | |
| 'computation' => '(SELECT num_order FROM glpi_plugin_order_orders WHERE glpi_plugin_order_orders.id = glpi_plugin_order_bills.plugin_order_orders_id)', | |
| ]; |
Comment on lines
+203
to
+209
| 'table' => 'glpi_plugin_order_bills', | ||
| 'field' => 'order_name', | ||
| 'name' => __('Order', 'order'), | ||
| 'datatype' => 'string', | ||
| 'nosearch' => true, | ||
| 'massiveaction' => false, | ||
| 'computation' => '(SELECT name FROM glpi_plugin_order_orders WHERE glpi_plugin_order_orders.id = glpi_plugin_order_bills.plugin_order_orders_id)', |
There was a problem hiding this comment.
This should allow searching to list all bills associated with a specific order.
There is no need to use computation; refer to the previous search option that uses the 'dropdown' data type.
|
This PR has not progressed for quite some time. I will go ahead and close it. Please feel free to reopen it if needed and resolve any conflicts. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bill value in list option