Skip to content

Conversation

@yutiPML
Copy link
Collaborator

@yutiPML yutiPML commented Mar 27, 2025

Description of Work

added additional variable to the outputs of CO2clc and passed it up the chain so that it can be saved in a new diagnostic variable id_Hplus

please note that the recalculated pH from the Hplus concentration would have a bias compared to the pH originally saved from the model because the latter is calculated on the concentration per unit of mass rather than per unit of volume.

Testing Instructions

  1. compile
  2. run a testcase saving both Hplus and pH at dt resolution
  3. calculate pH from Hplus (-log10(Hplus/1e6)) - 1e6 is to trasnform mmol/m3 to mol/L
  4. check that the difference between the recalculated pH and the original pH is of the order of 0.01 (at density around 1026)

@yutiPML yutiPML linked an issue Mar 27, 2025 that may be closed by this pull request
@yutiPML yutiPML requested a review from glessin March 27, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hydrogen ions concentration is not a diagnostic variable

3 participants