New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump build target, correctly downlevel transpile #96

Open

CodyJasonBennett wants to merge 1 commit into pmndrs:master from CodyJasonBennett:fix/async-transpile

Member

CodyJasonBennett commented Jul 17, 2022 •

edited

Loading

Fixes #89 and #86, following up #94, where things aren't being transpiled correctly.

According to https://esbuild.github.io/api/#target:

If you use a syntax feature that esbuild doesn't yet have support for transforming to your current language target, esbuild will generate an error where the unsupported syntax is used. This is often the case when targeting the es5 language version, for example, since esbuild only supports transforming most newer JavaScript syntax features to es6.

Also see https://esbuild.github.io/content-types/#javascript as for JS features by version.


          fix: bump build target

270770b

CodyJasonBennett mentioned this pull request

Crash in an old browser. (iPad Mini 1 Safari 9) #86

Open

CodyJasonBennett changed the title ~~fix: bump build target~~ fix: bump build target, correctly downlevel transpile

puckey force-pushed the master branch 2 times, most recently from 467f920 to 8d22129 Compare

January 31, 2024 13:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet