fix(fiber): normalize viewport event prefixes#3758
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f216fa2:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canvassupports overriding pointer coordinate extraction viaeventPrefix, but prefixes likeclientandpageproduce viewport/document coordinates instead of coordinates local to the canvas bounds. Those values were normalized directly against the canvas size, so an offset canvas produced shifted pointer coordinates and raycasts.This normalizes
clientX/clientYby the canvas bounds andpageX/pageYby the bounds plus window scroll. Offset-like prefixes keep their existing behavior.Test Plan
npx jest packages/fiber/tests/events.test.tsx --runInBandnpx eslint packages/fiber/src/web/Canvas.tsx packages/fiber/tests/events.test.tsxnpx prettier --check packages/fiber/src/web/Canvas.tsx packages/fiber/tests/events.test.tsxnpm run -s typechecknpm run -s build