-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds demo time sample #5423
Adds demo time sample #5423
Conversation
Sample PR validation for #5423
|
Validation | Status |
---|---|
Pull request affects only one folder | |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | ✅ Succeeded |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@Adam-it please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
the changes outside of the sample folder were done by the gh action |
Good catch. I'll add logic to ignore those changes. |
Sample PR validation for #5423
|
Validation | Status |
---|---|
Pull request affects only one folder | |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | ✅ Succeeded |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@Adam-it please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Thank you @Adam-it for your sample! Always appreciated! We'd love to have your sample featured in one of our future community calls. If haven't done so yet, and you'd be interested on showing this great sample in a public community call, please fill in following form and we'll get you scheduled - aka.ms/community/request/demo Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?
The PR adds a new sample Demo Time which allows you to add presentation mode to any page of any site and treat sections on pages as there would be slides.
This web part is a total hack that interacts with pages DOM which is not recommended.
This web part is a kind of a POC created for the SharePoint Hackathon
Node Version
Node version used:
v18.20.3
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js