-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cfernandes spfx branch #5424
Cfernandes spfx branch #5424
Conversation
…ams. I built this SPFx web part to enable rendering Mermaid syntax directly.
Updated the README.md file
…ams. I built this SPFx web part to enable rendering Mermaid syntax directly.
Added Assets folder - Markdown web part in SharePoint Online does not support Mermaid diagrams. I built this SPFx web part to enable rendering Mermaid syntax directly.
Sample PR validation for #5424
|
Validation | Status |
---|---|
Pull request affects only one folder | ✅ Succeeded |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | |
Sample requires a .nvmrc file | |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@cfernandes-muhimbi please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Sample PR validation for #5424
|
Validation | Status |
---|---|
Pull request affects only one folder | ✅ Succeeded |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@cfernandes-muhimbi please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Resolved the stat image warnings
Sample PR validation for #5424
|
Validation | Status |
---|---|
Pull request affects only one folder | ✅ Succeeded |
Sample folder name follows naming convention | ✅ Succeeded |
README.md contains visitor stat image | |
Sample requires a .nvmrc file | ✅ Succeeded |
Sample requires a README.md | ✅ Succeeded |
Sample requires a screenshot .png in assets folder | ✅ Succeeded |
No .sppkg file | ✅ Succeeded |
No node_modules folder | ✅ Succeeded |
No lib folder | ✅ Succeeded |
@cfernandes-muhimbi please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
Sample PR validation for #5424✅ Validation status: successWe automatically validate all pull requests against our contribution guidance to ensure that all samples provide a consistent experience to our community. In order to merge this PR in a timely manner, the following criteria must be met:
|
Thank you @cfernandes-muhimbi for your sample! Always appreciated! We'd love to have your sample featured in one of our future community calls. If haven't done so yet, and you'd be interested on showing this great sample in a public community call, please fill in following form and we'll get you scheduled - aka.ms/community/request/demo Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
What's in this Pull Request?
I created this web part to add Mermaid diagram support in SharePoint Online as part of my tutorial series. While working on it, I found this discussion thread: Displaying Mermaid Diagrams in SharePoint Online Markdown Web Parts, which highlights the need for a proper solution.
Since the native Markdown web part in SharePoint Online does not support Mermaid diagrams, I built this SPFx web part to enable rendering Mermaid syntax directly. I'm sharing this in case others find it useful or have suggestions for improvements.
Node Version
Node version used:
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js