fix: update pnpm to 11.1.1#248
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📜 Recent review details🔇 Additional comments (3)
📝 WalkthroughWalkthroughBump pnpm and bundled Changespnpm Bootstrap Upgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
why do you need to update pnpm in the action? This action will install any pnpm version that you specify in your project. |
|
@zkochan it doesn't use the specified version in the package.json in v6 of the action, it only uses the bootstrapped version. You can see the error in this dbot run in one of my repos. The action is using pnpm Pinning to v5 of the action and using |
|
Try adding |
|
That does resolve the issue. But I think it is not correct that I must configure that in my package.json to accomodate the CI pipeline instead of the pipeline selecting based on the package.json which it did previously. It is not documented behaviour and is a breaking change from v5 to v6 that is not captured anywhere, so if this is the direction the action is taking can the readme please be updated to reflect this. However I do think it would be better to have the action resolve the version based on the selected version in the package.json instead of having required CI config in the package.json which could conflict with how teams currently use the Also, does this mean that the action is dropping support for selecting the version based on |
|
👋 Hello! I think I'm suffering from the same issue as @djmurphy32 has pointed out. My failure result is a little different: "packageManager": "pnpm@11.0.6",
I assumed that the right course of action was to update the version within the action, but perhaps the real fix is as @djmurphy32 mentions. In the meantime I will try both the suggestion for the Thanks both. |
- uses: pnpm/action-setup@v6
with:
version: latestThis will work |
Updates the bundled pnpm to v11.1.1.
Generated by running:
node scripts/update-bootstrap.mjs 11.1.1pnpm run buildSummary by CodeRabbit