-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update many packages #14
Conversation
Note that I finally found (and hopefully fixed) the initial warning that started me down this path in pnpm/pnpm#8068 Also worth noting is that if/when this PR is accepted, https://github.com/pnpm/pnpm/blob/fd6cd2781716dd6c020474beae2f3a3da8493e6b/package.json#L23 will need to be updated to remove the forced Node16 installation (that does not work under NixOS). |
Could you please review this @zkochan ? Don't want to be an annoyance, but would generally like to avoid pulling in so many outdated packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests don't seem to pass.
After exploring why a package deprecation kept popping up, I followed the thread to this project and noticed that it had been some time since anyone had run
pnpm up --latest
. I've done that and gottenpnpm test
to run without complaint.Figured there were enough changes to warrant a major semver bump. Unsure if there are other contribution guidelines or suggestions, so opening a PR for review.
Alas the original warning is still popping up, but that's further upstream...