-
Notifications
You must be signed in to change notification settings - Fork 2
chore: use node 24 #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: use node 24 #421
Conversation
|
Warning Rate limit exceeded@feloy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates Node.js runtime version from 20–22 to 24 across GitHub Actions workflows, package engine requirements, and type definitions. No logic, control flow, or error handling modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/build-next.yaml.github/workflows/pr-check.yaml.github/workflows/release.yamlpackage.jsonpackages/backend/package.jsonpackages/frontend/package.json
🧰 Additional context used
🪛 GitHub Actions: pr-check
package.json
[error] 1-1: Lockfile and manifest mismatch: @types/node version in manifest (^24) does not match lockfile (^22).
packages/backend/package.json
[error] 1-1: Lockfile and manifest mismatch: @types/node version in manifest (^24) does not match lockfile (^22).
🔇 Additional comments (5)
packages/frontend/package.json (1)
36-36: Dependency update aligns with Node.js 24 upgrade.The
@types/nodeupdate is correct. Note that the lockfile regeneration (flagged in the backend package review) will resolve the pipeline failure for this file as well..github/workflows/release.yaml (1)
126-126: LGTM!The Node.js version update in the release workflow is consistent with the other workflow updates and aligns with the PR objectives.
.github/workflows/pr-check.yaml (1)
40-40: LGTM!The Node.js version update from 20 to 24 in the pr-check workflow aligns with the PR objectives and is consistent with the other workflow updates.
package.json (1)
10-10: LGTM—Electron v40 compatibility with Node.js 24 confirmed.The engines.node update correctly enforces Node.js 24 minimum version. Electron v40 bundles Node.js 24.11.1, confirming full compatibility with the new requirement.
.github/workflows/build-next.yaml (1)
38-38: Node.js 24 is available and stable for GitHub Actions.The setup-node action officially supports node-version: 24, and GitHub Actions has migrated to Node.js 24 LTS. Node.js 24 entered long-term support (LTS) in October. The version change aligns with GitHub's direction as runners will begin using Node24 by default beginning March 4th, 2026.
Signed-off-by: Philippe Martin <[email protected]>
57fd50e to
00cca95
Compare
fixes #416