Skip to content

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Dec 23, 2025

fixes #416

@feloy feloy requested a review from a team as a code owner December 23, 2025 09:08
@feloy feloy requested review from axel7083, benoitf and simonrey1 and removed request for a team December 23, 2025 09:08
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Warning

Rate limit exceeded

@feloy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 2 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 57fd50e and 00cca95.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • .github/workflows/build-next.yaml
  • .github/workflows/pr-check.yaml
  • .github/workflows/release.yaml
  • package.json
  • packages/backend/package.json
  • packages/frontend/package.json
📝 Walkthrough

Walkthrough

Updates Node.js runtime version from 20–22 to 24 across GitHub Actions workflows, package engine requirements, and type definitions. No logic, control flow, or error handling modifications.

Changes

Cohort / File(s) Change Summary
GitHub Actions Workflows
​.github/workflows/build-next.yaml, ​.github/workflows/pr-check.yaml, ​.github/workflows/release.yaml
Updated actions/setup-node Node.js version from 20–22 to 24 in all three workflow files to align CI/CD environment with v24 runtime.
Package Configuration & Type Definitions
package.json, packages/backend/package.json, packages/frontend/package.json
Updated root-level engines.node requirement from ">=20.9.0" to ">=24.0.0" and bumped @types/node from ^22 (and ^22.19.3) to ^24 in backend and frontend packages for type compatibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating to Node.js 24. It directly corresponds to the primary objective in the linked issue.
Description check ✅ Passed The description references the linked issue #416, which relates to updating Node.js to v24. The reference is relevant and connects to the changeset.
Linked Issues check ✅ Passed The PR successfully fulfills all coding-related requirements from issue #416: workflow files updated to use Node.js 24, package.json engines.node bumped to >=24.0.0, and @types/node dependencies updated to ^24.
Out of Scope Changes check ✅ Passed All changes are directly scoped to updating Node.js to v24 across workflows, root package.json, and type dependencies. No unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25baac7 and 57fd50e.

📒 Files selected for processing (6)
  • .github/workflows/build-next.yaml
  • .github/workflows/pr-check.yaml
  • .github/workflows/release.yaml
  • package.json
  • packages/backend/package.json
  • packages/frontend/package.json
🧰 Additional context used
🪛 GitHub Actions: pr-check
package.json

[error] 1-1: Lockfile and manifest mismatch: @types/node version in manifest (^24) does not match lockfile (^22).

packages/backend/package.json

[error] 1-1: Lockfile and manifest mismatch: @types/node version in manifest (^24) does not match lockfile (^22).

🔇 Additional comments (5)
packages/frontend/package.json (1)

36-36: Dependency update aligns with Node.js 24 upgrade.

The @types/node update is correct. Note that the lockfile regeneration (flagged in the backend package review) will resolve the pipeline failure for this file as well.

.github/workflows/release.yaml (1)

126-126: LGTM!

The Node.js version update in the release workflow is consistent with the other workflow updates and aligns with the PR objectives.

.github/workflows/pr-check.yaml (1)

40-40: LGTM!

The Node.js version update from 20 to 24 in the pr-check workflow aligns with the PR objectives and is consistent with the other workflow updates.

package.json (1)

10-10: LGTM—Electron v40 compatibility with Node.js 24 confirmed.

The engines.node update correctly enforces Node.js 24 minimum version. Electron v40 bundles Node.js 24.11.1, confirming full compatibility with the new requirement.

.github/workflows/build-next.yaml (1)

38-38: Node.js 24 is available and stable for GitHub Actions.

The setup-node action officially supports node-version: 24, and GitHub Actions has migrated to Node.js 24 LTS. Node.js 24 entered long-term support (LTS) in October. The version change aligns with GitHub's direction as runners will begin using Node24 by default beginning March 4th, 2026.

Signed-off-by: Philippe Martin <[email protected]>
@feloy feloy force-pushed the chore-416/use-node-24 branch from 57fd50e to 00cca95 Compare December 23, 2025 09:13
@feloy feloy marked this pull request as draft December 23, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update usage of Node.js to v24

1 participant