Skip to content

refactor(rust): Make GetBatchState polling functions unsafe #23795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jul 29, 2025

Hides the actual impls as private functions and marks them unsafe. The struct now exposes an async next() instead that can be safely used.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jul 29, 2025
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (ffb34bf) to head (c7299e0).

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sources/batch.rs 84.21% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23795      +/-   ##
==========================================
- Coverage   81.39%   81.37%   -0.03%     
==========================================
  Files        1652     1652              
  Lines      224344   224356      +12     
  Branches     2872     2872              
==========================================
- Hits       182609   182566      -43     
- Misses      41016    41071      +55     
  Partials      719      719              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nameexhaustion nameexhaustion marked this pull request as ready for review July 29, 2025 10:01
@nameexhaustion nameexhaustion marked this pull request as draft July 29, 2025 10:46
@nameexhaustion nameexhaustion marked this pull request as ready for review July 29, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant