fix: Propagate null by column values in rolling_*_by#27367
Open
gautamvarmadatla wants to merge 2 commits intopola-rs:mainfrom
Open
fix: Propagate null by column values in rolling_*_by#27367gautamvarmadatla wants to merge 2 commits intopola-rs:mainfrom
by column values in rolling_*_by#27367gautamvarmadatla wants to merge 2 commits intopola-rs:mainfrom
Conversation
gautamvarmadatla
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
github-actions
Bot
added
fix
Contributor
Author
|
CI failed again despite retriggering. looks like a pre-existing macOS runner disk space issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27366
I filtered the input to non-null
byrows, computed the rolling aggregation on that subset, then scattered the results back to their original positions using a nullableIdxCa. Nullbyrows should now produce null output, instead of panicking.