fix: Fix skip_batches logic for NaN#27673
Merged
Merged
Conversation
ritchie46
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
orlp
as code owners
github-actions
Bot
added
fix
Contributor
|
The uncompressed lib size after this PR is 60.1638 MB. |
Contributor
|
The uncompressed lib size after this PR is 59.9854 MB. |
Contributor
|
The uncompressed lib size after this PR is 60.1638 MB. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27673 +/- ##
==========================================
- Coverage 81.48% 80.78% -0.71%
==========================================
Files 1840 1840
Lines 256109 256113 +4
Branches 3181 3181
==========================================
- Hits 208696 206890 -1806
- Misses 46588 48397 +1809
- Partials 825 826 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdementen
reviewed
May 20, 2026
| assert sbp(pl.col("x") > NaN) is not None # Can skip. Nothing > NaN under TotalOrd. | ||
| assert sbp(pl.col("x") >= 5.0) is None # No skip. Hidden NaN satisfies >=. | ||
| assert sbp(pl.col("x") >= NaN) is not None # Can skip. Nothing > NaN. | ||
| assert sbp(pl.col("x") > NaN) is not None # Can skip. Nothing > NaN. |
There was a problem hiding this comment.
Am I missing something or this particular test/line is already present two lines above?
Member
Author
There was a problem hiding this comment.
Nope, you are not. Good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a flaky hypothesis test. Hitting test case found with AI.
GtEqis not safe under total order as stats excludeNaN.