fix issue 58 #72
Merged
fix issue 58 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haozhicui <[email protected]>
chuntaojun
reviewed
Feb 26, 2025
balancer.go
Outdated
| insRes, err) | ||
| } | ||
|
|
||
| fmt.Printf("report circuitBreaker [%v-%s] for instance %s/%s:%d "+ |
There was a problem hiding this comment.
这里 fmt.Printf 不合适吧？
已修改
Signed-off-by: haozhicui <[email protected]>
chuntaojun
reviewed
Feb 26, 2025
balancer.go
Outdated
| insRes, err := model.NewInstanceResource(&model.ServiceKey{ | ||
| Namespace: r.namespace, | ||
| Service: r.service, | ||
| }, caller, "http", instance.GetHost(), instance.GetPort()) |
There was a problem hiding this comment.
这个 protocol 应该是 instance.GetProtocol() ? 如果没有默认应该是 grpc？
There was a problem hiding this comment.
这个 protocol 应该是 instance.GetProtocol() ? 如果没有默认应该是 grpc？
已修复
Signed-off-by: haozhicui <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes #58
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.