Skip to content
revive

Merge pull request #232 from captainroy-hy/royyuewang/fix/ratelimit-g… #323

Sign in to view logs

Merge pull request #232 from captainroy-hy/royyuewang/fix/ratelimit-g…

Merge pull request #232 from captainroy-hy/royyuewang/fix/ratelimit-g… #323

Triggered via push February 10, 2025 02:16
@sak0sak0
pushed 5141069
main
Status Success
Total duration 37s
Artifacts –

revive.yml

on: push
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

60 warnings
Run Revive Action (1.15.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.15.x): benchmark/benchmain/main.go#L47
const operationRpcNaming should be operationRPCNaming
Run Revive Action (1.15.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/circuitbreaker/service/provider/main.go#L17
should have a package comment
Run Revive Action (1.15.x): examples/circuitbreaker/instance/consumer/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/flow/registerstate/register_flow.go#L71
exported method PutRegister returns unexported type *registerstate.registerState, which can be annoying to use
Run Revive Action (1.15.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.17.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.17.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/plugin/loadbalancer/loadbalancer.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.17.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.17.x): benchmark/benchmain/main.go#L46
const operationRpcDirect should be operationRPCDirect
Run Revive Action (1.17.x): pkg/plugin/configconnector/config_connector.go#L19
should have a package comment
Run Revive Action (1.18.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/watch/service/longpull/main.go#L52
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.18.x): examples/mock/main.go#L1
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.18.x): examples/watch/service/notify/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/quickstart/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/loadbalancer/provider/main.go#L18
should have a package comment
Run Revive Action (1.18.x): benchmark/benchsimple/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/circuitbreaker/service/consumer/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/ratelimit/provider/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/circuitbreaker/service/provider/main.go#L17
should have a package comment
Run Revive Action (1.19.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/route/dynamic/provider/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/mock/main.go#L1
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.16.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.16.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/clock/clock.go#L77
exported function CurrentMillis should have comment or be unexported
Run Revive Action (1.16.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): pkg/plugin/ratelimiter/model.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/plugin/serverconnector/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/instance/provider/main.go#L17
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/interface/consumer/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/interface/provider/main.go#L17
should have a package comment
Run Revive Action (1.20.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.20.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.20.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/circuitbreaker/service/consumer/main.go#L18
should have a package comment