Skip to content
revive

修复分布式限流场景下rpc连接泄漏的问题 #324

Sign in to view logs

修复分布式限流场景下rpc连接泄漏的问题

修复分布式限流场景下rpc连接泄漏的问题 #324

Triggered via pull request February 11, 2025 02:41
@captainroy-hycaptainroy-hy
opened #233
captainroy-hy:cherrypick/fix/ratelimit-grpc-leaking
Status Success
Total duration 40s
Artifacts –

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

60 warnings
Run Revive Action (1.16.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/activehealthcheck/main.go#L129
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): pkg/plugin/servicerouter/servicerouter.go#L30
exported type FailOverType should have comment or be unexported
Run Revive Action (1.16.x): pkg/plugin/servicerouter/util.go#L58
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): examples/quickstart/consumer/main.go#L58
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/stat/plugin/plug.go#L29
type name will be used as plugin.PluginAPI by other packages, and that stutters; consider calling this API
Run Revive Action (1.16.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment
Run Revive Action (1.16.x): plugin/circuitbreaker/common/half_open.go#L135
exported const ToClose should have comment (or a comment on this block) or be unexported
Run Revive Action (1.16.x): examples/watch/instance/longpull/main.go#L88
should omit type uint64 from declaration of var index; it will be inferred from the right-hand side
Run Revive Action (1.19.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.19.x): benchmark/benchmain/main.go#L18
should have a package comment
Run Revive Action (1.19.x): benchmark/benchsimple/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/fallback/main.go#L18
should have a package comment
Run Revive Action (1.19.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/serverconnector/proxy.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/localregistry/localregistry.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/consumer/main.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.18.x): examples/circuitbreaker/consumer/main.go#L57
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.18.x): benchmark/benchsimple/main.go#L18
should have a package comment
Run Revive Action (1.18.x): plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.18.x): test/all_suite_test.go#L33
should not use dot imports
Run Revive Action (1.18.x): plugin/ratelimiter/common/ratelimit_slice_window.go#L66
if block ends with a return statement, so drop this else and outdent its block
Run Revive Action (1.17.x): examples/configuration/group/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/model/local/value.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/configuration/normal/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.17.x): pkg/model/pb/metric/v2/code.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/ratelimit/provider/main.go#L18
should have a package comment
Run Revive Action (1.17.x): benchmark/benchmain/main.go#L325
parameter 'pos' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.17.x): examples/route/dynamic/consumer/main.go#L18
should have a package comment
Run Revive Action (1.17.x): examples/route/nearby/consumer/main.go#L75
parameter 'r' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.15.x): plugin/ratelimiter/common/ratelimit_slice_window.go#L66
if block ends with a return statement, so drop this else and outdent its block
Run Revive Action (1.15.x): pkg/algorithm/hash/base.go#L32
type name will be used as hash.HashFuncWithSeed by other packages, and that stutters; consider calling this FuncWithSeed
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.15.x): plugin/ratelimiter/unirate/bucket_leaky.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/crud/main.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/configuration/encrypt/main.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/common/plugin.go#L18
should have a package comment
Run Revive Action (1.15.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/register/plugins.go#L21
a blank import should be only in a main or test package, or have a comment justifying it
Run Revive Action (1.20.x): pkg/plugin/register/plugins.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/instance/notify/main.go#L76
exported type TestListener should have comment or be unexported
Run Revive Action (1.20.x): pkg/plugin/ratelimiter/model.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/service/longpull/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/watch/service/notify/main.go#L44
exported type TestListener should have comment or be unexported
Run Revive Action (1.20.x): examples/watchinstance/main.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/serverconnector/proxy.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/ratelimit/consumer/main.go#L18
should have a package comment
Run Revive Action (1.20.x): examples/extensions/zeroprotect/main.go#L18
should have a package comment