Skip to content

Commit

Permalink
feat: merge next to develop
Browse files Browse the repository at this point in the history
* feat: rewrite without support for IoC container and before,after lifecycle

Removed the dependency on AdoniJS application. Also removed the concept of before and after hooks.
After hooks can be represented as cleanup functions now

BREAKING CHANGE: The API is completely different from version 4.0.0

* docs(readme): update documentation for the rewrite

* docs(readme): update docs

* chore(package): set tag to next

* docs: update installation command to use @next tag

* refactor: remove application typings reference from tsconfig file

* chore(release): 6.0.0-0

* chore: update dependencies

* refactor: set isCleanupPending flag to false by default

The flag should be set to true only when the run method has been
called

* chore(release): 6.0.1-0

* chore: update dependencies

* refactor: run cleanup functions in reverse order

* chore(release): 6.0.2-0

* refactor: rewrite in TypeScript

* feat: add support to register hook providers

* docs(README): initial docs

* refactor: improve events generic type

* docs: add documentation

* docs(README): grammatical improvements

* ci: fix import url to be cross platform

* chore: ignore package-lock file

* chore(release): 7.0.0-0

* refactor: remove providers and executor in favor of object based hooks

The object based hooks can also work as a provider and executor both by
wrapping the underlying method inside another function

* chore(release): 7.1.0-0

* chore: update dependencies

* docs(README): fix badge url for github workflow

* chore(release): 7.1.1-0

* chore: update dependencies

* chore: update dependencies

* chore(release): 7.1.1-1

* chore: update dependencies

* chore(release): 7.1.1-2

* chore: update dependencies

* chore: migrate to adonisjs tooling config

* chore: use prettier config from adonisjs tooling and format source

* chore: use tsconfig from adonisjs tooling config

* feat: add helper types

* chore: add engines to package.json file

* chore(release): 7.1.1-3

* chore: update dependencies

* chore: upgrade japa to v3

* ci: add linting and typechecking in ci

* chore(release): 7.1.1-4

* chore: update dependencies

* docs: update README

* chore(release): 7.1.1-5

* chore: update dependencies

* feat: allow running hooks in reverse order

* test: add test for passing multiple arguments to hooks

* chore(release): 7.1.1-6

* chore: update dependencies

* chore: use tsup for bundling
  • Loading branch information
thetutlage authored Oct 14, 2023
1 parent cc7a81a commit 42858a5
Show file tree
Hide file tree
Showing 26 changed files with 1,345 additions and 922 deletions.
7 changes: 0 additions & 7 deletions .bin/test.js

This file was deleted.

70 changes: 0 additions & 70 deletions .github/COMMIT_CONVENTION.md

This file was deleted.

38 changes: 0 additions & 38 deletions .github/CONTRIBUTING.md

This file was deleted.

23 changes: 0 additions & 23 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

28 changes: 0 additions & 28 deletions .github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

170 changes: 170 additions & 0 deletions .github/labels.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
[
{
"name": "Priority: Critical",
"color": "ea0056",
"description": "The issue needs urgent attention",
"aliases": []
},
{
"name": "Priority: High",
"color": "5666ed",
"description": "Look into this issue before picking up any new work",
"aliases": []
},
{
"name": "Priority: Medium",
"color": "f4ff61",
"description": "Try to fix the issue for the next patch/minor release",
"aliases": []
},
{
"name": "Priority: Low",
"color": "87dfd6",
"description": "Something worth considering, but not a top priority for the team",
"aliases": []
},
{
"name": "Semver: Alpha",
"color": "008480",
"description": "Will make it's way to the next alpha version of the package",
"aliases": []
},
{
"name": "Semver: Major",
"color": "ea0056",
"description": "Has breaking changes",
"aliases": []
},
{
"name": "Semver: Minor",
"color": "fbe555",
"description": "Mainly new features and improvements",
"aliases": []
},
{
"name": "Semver: Next",
"color": "5666ed",
"description": "Will make it's way to the bleeding edge version of the package",
"aliases": []
},
{
"name": "Semver: Patch",
"color": "87dfd6",
"description": "A bug fix",
"aliases": []
},
{
"name": "Status: Abandoned",
"color": "ffffff",
"description": "Dropped and not into consideration",
"aliases": ["wontfix"]
},
{
"name": "Status: Accepted",
"color": "e5fbf2",
"description": "The proposal or the feature has been accepted for the future versions",
"aliases": []
},
{
"name": "Status: Blocked",
"color": "ea0056",
"description": "The work on the issue or the PR is blocked. Check comments for reasoning",
"aliases": []
},
{
"name": "Status: Completed",
"color": "008672",
"description": "The work has been completed, but not released yet",
"aliases": []
},
{
"name": "Status: In Progress",
"color": "73dbc4",
"description": "Still banging the keyboard",
"aliases": ["in progress"]
},
{
"name": "Status: On Hold",
"color": "f4ff61",
"description": "The work was started earlier, but is on hold now. Check comments for reasoning",
"aliases": ["On Hold"]
},
{
"name": "Status: Review Needed",
"color": "fbe555",
"description": "Review from the core team is required before moving forward",
"aliases": []
},
{
"name": "Status: Awaiting More Information",
"color": "89f8ce",
"description": "Waiting on the issue reporter or PR author to provide more information",
"aliases": []
},
{
"name": "Status: Need Contributors",
"color": "7057ff",
"description": "Looking for contributors to help us move forward with this issue or PR",
"aliases": []
},
{
"name": "Type: Bug",
"color": "ea0056",
"description": "The issue has indentified a bug",
"aliases": ["bug"]
},
{
"name": "Type: Security",
"color": "ea0056",
"description": "Spotted security vulnerability and is a top priority for the core team",
"aliases": []
},
{
"name": "Type: Duplicate",
"color": "00837e",
"description": "Already answered or fixed previously",
"aliases": ["duplicate"]
},
{
"name": "Type: Enhancement",
"color": "89f8ce",
"description": "Improving an existing feature",
"aliases": ["enhancement"]
},
{
"name": "Type: Feature Request",
"color": "483add",
"description": "Request to add a new feature to the package",
"aliases": []
},
{
"name": "Type: Invalid",
"color": "dbdbdb",
"description": "Doesn't really belong here. Maybe use discussion threads?",
"aliases": ["invalid"]
},
{
"name": "Type: Question",
"color": "eceafc",
"description": "Needs clarification",
"aliases": ["help wanted", "question"]
},
{
"name": "Type: Documentation Change",
"color": "7057ff",
"description": "Documentation needs some improvements",
"aliases": ["documentation"]
},
{
"name": "Type: Dependencies Update",
"color": "00837e",
"description": "Bump dependencies",
"aliases": ["dependencies"]
},
{
"name": "Good First Issue",
"color": "008480",
"description": "Want to contribute? Just filter by this label",
"aliases": ["good first issue"]
}
]
4 changes: 2 additions & 2 deletions .github/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ daysUntilClose: 7

# Issues with these labels will never be considered stale
exemptLabels:
- "Type: Security"
- 'Type: Security'

# Label to use when marking an issue as stale
staleLabel: "Status: Abandoned"
staleLabel: 'Status: Abandoned'

# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: checks
on:
- push
- pull_request

jobs:
test:
uses: poppinss/.github/.github/workflows/test.yml@main

lint:
uses: poppinss/.github/.github/workflows/lint.yml@main

typecheck:
uses: poppinss/.github/.github/workflows/typecheck.yml@main
22 changes: 0 additions & 22 deletions .github/workflows/test.yml

This file was deleted.

3 changes: 2 additions & 1 deletion .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"
HUSKY_GIT_PARAMS=$1 node ./node_modules/@adonisjs/mrm-preset/validate-commit/conventional/validate.js

npx --no -- commitlint --edit
Loading

0 comments on commit 42858a5

Please sign in to comment.