Debug workflow #287
Merged
Debug workflow #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liked parameters with different values [fixed] jobs dependencies [partly fixed, still not OK] (#286)
which were not exhaustive enough
|
tests are broken for now... |
|
tests pass again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these modifs I was able to run a first complete Morphologist pipeline.
The sulci CNN recognition results are wrong however, so there must still be a problem somewhere, but it's already an improvement.
The method Pipeline.get_linked_items() should be reworked (maybe after a discussion), see #286