Skip to content

Reactivate ploidychecks#381

Open
stschiff wants to merge 16 commits intomasterfrom
reactivate_ploidychecks
Open

Reactivate ploidychecks#381
stschiff wants to merge 16 commits intomasterfrom
reactivate_ploidychecks

Conversation

@stschiff
Copy link
Copy Markdown
Member

This PR simply reactivates code that we had commented out, which checks whether the Ploidy-Information in the Janno agrees with the actual genotype data. If the Janno file claims that a particular sample should be haploid, but the genotype data contains heterozygotes, this will now throw an error. As far as I could test, all current packages in our archives pass this test, so I think it's safe to reintroduce.

Note that this PR is on top of #375, so should be merged after that one.

@stschiff stschiff changed the base branch from master to strandcheck May 5, 2026 10:51
@stschiff stschiff changed the base branch from strandcheck to master May 5, 2026 10:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 59.59596% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.13%. Comparing base (edc8849) to head (31f45a5).

Files with missing lines Patch % Lines
src/Poseidon/Core/GenotypeData.hs 65.75% 15 Missing and 10 partials ⚠️
src/Poseidon/Core/Package.hs 55.00% 3 Missing and 6 partials ⚠️
...Poseidon/CLI/Trident/OptparseApplicativeParsers.hs 0.00% 3 Missing ⚠️
src/Poseidon/CLI/Trident/Forge.hs 0.00% 1 Missing and 1 partial ⚠️
src/Poseidon/CLI/Xerxes/FStats.hs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   51.80%   52.13%   +0.32%     
==========================================
  Files          36       36              
  Lines        5870     5891      +21     
  Branches      641      647       +6     
==========================================
+ Hits         3041     3071      +30     
+ Misses       2188     2173      -15     
- Partials      641      647       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant