Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 51.80% 52.13% +0.32%
==========================================
Files 36 36
Lines 5870 5891 +21
Branches 641 647 +6
==========================================
+ Hits 3041 3071 +30
+ Misses 2188 2173 -15
- Partials 641 647 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply reactivates code that we had commented out, which checks whether the Ploidy-Information in the Janno agrees with the actual genotype data. If the Janno file claims that a particular sample should be
haploid, but the genotype data contains heterozygotes, this will now throw an error. As far as I could test, all current packages in our archives pass this test, so I think it's safe to reintroduce.Note that this PR is on top of #375, so should be merged after that one.