Skip to content

Fix #791 by handling interactive_data_values properly #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzo-w wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #791 by handling interactive_data_values properly #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562ae28
Fix #791 on upstream repo
lorenzo-w Oct 31, 2025
cd7b56f
Refactor pipe function to use Concatenate in type hints
lorenzo-w Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions great_tables/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,8 +1375,8 @@ def nanoplot_options(
show_reference_area = True if show_reference_area is None else show_reference_area
show_vertical_guides = True if show_vertical_guides is None else show_vertical_guides
show_y_axis_guide = True if show_y_axis_guide is None else show_y_axis_guide

interactive_data_values = interactive_data_values or True
interactive_data_values = True if interactive_data_values is None else interactive_data_values

# y_val_fmt_fn, y_axis_fmt_fn, and y_ref_line_fmt_fn
# are not assigned to a default value
Expand Down
4 changes: 2 additions & 2 deletions great_tables/_pipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

from typing import TYPE_CHECKING, Callable
from typing_extensions import ParamSpec
from typing_extensions import ParamSpec, Concatenate

if TYPE_CHECKING:
from .gt import GT
Expand All @@ -10,7 +10,7 @@
P = ParamSpec("P")


def pipe(self: "GT", func: Callable[P, "GT"], *args: P.args, **kwargs: P.kwargs) -> "GT":
def pipe(self: "GT", func: Callable[Concatenate["GT", P], "GT"], *args: P.args, **kwargs: P.kwargs) -> "GT":
"""
Provide a structured way to chain a function for a GT object.

Expand Down