Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Ruff #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apply Ruff #82

wants to merge 2 commits into from

Conversation

tylerriccio33
Copy link
Contributor

Applied the ruff linting settings added. This is a massive pr...

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (9b78377) to head (35e1d43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          16       16           
  Lines        3241     3241           
=======================================
  Hits         3209     3209           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tylerriccio33
Copy link
Contributor Author

I must be in ruff hell, I cannot for the life of me figure out why those commas were formatted like that. I added the exclusions, add a new clean target in the Makefile for ruff cache and applied the linter, which seemingly did nothing.

@rich-iannone
Copy link
Member

Yeah, it’s a weird one. One thing that might be helpful is to have a video call to sort things out. I figure that once we collectively solve this, we’ll have a better time with all this in the near future!

If you’re game, could you send me an email to coordinate? My work email is in my GH profile. We have ruff and pre-commit set up in Great Tables so there’s some recent experience we could draw from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants