Skip to content

Fix styling for code in headers in the Help pane #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliasilge merged 2 commits into from
Dec 9, 2025
+5 −0
Merged

Fix styling for code in headers in the Help pane #10989

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c8bda
Fix styling for code in headers in the Help pane
juliasilge Dec 6, 2025
ea15fca
None of our help page generators make these deprecated elements
juliasilge Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions/positron-proxy/resources/scripts_help.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
a {
color: var(--vscode-textLink-foreground) !important;
}

code, pre, tt {
Copy link
Contributor

@dhruvisompura dhruvisompura Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the docs actually contain tt elements? This is a deprecated element and if we don't use them, we shouldn't need to target it for this style.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/tt

Copy link
Contributor Author

@juliasilge juliasilge Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out! I looked into how both R's help system and Python's pydoc make these HTML pages, and I don't believe anybody involved is using any deprecated tt elements.

font-family: var(--vscode-editor-font-family) !important;
font-size: inherit !important;
}
</style>
<style id="help-style-overrides">
::-webkit-scrollbar {
Expand Down
Loading