Use correct URI scheme when opening an editor or using opener service #10990
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
juliasilge
commented
Dec 7, 2025
Comment on lines
+267
to
+270
| const uri = URI.from({ | ||
| scheme: this._pathService.defaultUriScheme, | ||
| path: openWith.path | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I wondered if maybe this would fix #10893 but sadly, it does not. I still think we should make this change because this event won't do the right thing without this fix.
jennybc
approved these changes
Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
With this change, you can now correctly use the
UiFrontendEvent.OpenEditorevent such as viarstudioapi::navigateToFile()on a web build:It also makes reprex work:
This is similar to #10092 so I did a bit of an audit and fixed one more example of us inappropriately handling the scheme.
Release Notes
New Features
Bug Fixes
rstudioapi::navigateToFile()or when using reprexQA Notes
If you have a real file that really exists at a
/real/path/that/does/exist, then with this PR you should be able to successfully run.ps.ui.navigateToFile("/real/path/that/does/exist")from the R console both: