Skip to content

Conversation

@thomasboussekey
Copy link
Contributor

based on trixie as debian-bulleye is getting old

based on trixie as debian-bulleye is getting old
@ImreSamu
Copy link
Member

( @thomasboussekey )

Thank you for the PR!

1.)
The file 18-master/Dockerfile is missing,
but the GitHub CI build matrix is still referencing it.
Could you please either add the missing 18-master/Dockerfile
or remove it from the build matrix (and we can add it later)?

2.)
Currently, the images are generated with the tag postgis/postgis:18-3.5-alpine.
However, in this project the preferred approach is to use a tag like postgis/postgis:18beta3-3.5-alpine.
The reason is that the tag name should make it clear that this is still a beta version, not the final release.
This helps avoid surprises for users when PostgreSQL 18.0 is officially released and they later need to upgrade.
It also makes user support easier: if someone reports an issue, the image name itself shows whether they are using the beta or the final version.
This approach is also consistent with the upstream PostgreSQL Docker images - for example, at https://hub.docker.com/_/postgres there is no 18-trixie tag yet, only 18beta3-trixie.
So the only change needed here is to move the directory from 18-3.5 to 18beta3-3.5 with
git mv 18-3.5 18beta3-3.5 and then update the build matrix accordingly.
( For reference, here is a sample PR for 17beta3: https://github.com/postgis/docker-postgis/pull/388/files )

3.)
Additionally, if possible, please update the README.md:

  • The update.sh script generates a markdown table (for debian, alpine, test) in the logs. You can copy-paste that to refresh the relevant sections of the README.md.
  • Also, please update the date in the header line # Versions (2025-07-11) to match the modification date.

@thomasboussekey
Copy link
Contributor Author

( @thomasboussekey )

Thank you for the PR!

1.) The file 18-master/Dockerfile is missing, but the GitHub CI build matrix is still referencing it. Could you please either add the missing 18-master/Dockerfile or remove it from the build matrix (and we can add it later)?

2.) Currently, the images are generated with the tag postgis/postgis:18-3.5-alpine. However, in this project the preferred approach is to use a tag like postgis/postgis:18beta3-3.5-alpine. The reason is that the tag name should make it clear that this is still a beta version, not the final release. This helps avoid surprises for users when PostgreSQL 18.0 is officially released and they later need to upgrade. It also makes user support easier: if someone reports an issue, the image name itself shows whether they are using the beta or the final version. This approach is also consistent with the upstream PostgreSQL Docker images - for example, at https://hub.docker.com/_/postgres there is no 18-trixie tag yet, only 18beta3-trixie. So the only change needed here is to move the directory from 18-3.5 to 18beta3-3.5 with git mv 18-3.5 18beta3-3.5 and then update the build matrix accordingly. ( For reference, here is a sample PR for 17beta3: https://github.com/postgis/docker-postgis/pull/388/files )

3.) Additionally, if possible, please update the README.md:

  • The update.sh script generates a markdown table (for debian, alpine, test) in the logs. You can copy-paste that to refresh the relevant sections of the README.md.
  • Also, please update the date in the header line # Versions (2025-07-11) to match the modification date.

Thanks @ImreSamu , fix in progress!

For 1️⃣ , it should be named 18beta3-master, no?

For 2️⃣ , folder has been renamed

For 3️⃣ , for tomorrow 😪

@ImreSamu
Copy link
Member

For 1️⃣ , it should be named 18beta3-master, no?

Yes, correct.
But since Dockerfile.master.template has not been tested with Trixie,
there could be potential issues.
If you cannot resolve this now, I think it’s fine to leave it for later.

For 2️⃣ , folder has been renamed

Great!
In that case, please also update .github/workflows/main.yml accordingly.

@ImreSamu
Copy link
Member

In the meantime, PostGIS 3.6.0rc1 has also been released (2025/08/18):

If possible, could you also update:
17-3.6.0beta117-3.6.0rc1
And maybe even add a 18beta3-3.6.0rc1 version, which could be useful.

Of course, no problem if you prefer to skip these changes in this PR - I can add them later myself.

Thanks in advance!

@thomasboussekey
Copy link
Contributor Author

@ImreSamu should the script use this location, in order to download postgis 3.6rc1?
I'm not an expert of DEBIAN packages 🤣

@ImreSamu
Copy link
Member

should the script use this location,
in order to download postgis 3.6rc1?
I'm not an expert of DEBIAN packages 🤣

I’m not an expert either 🙂

Traditionally we use apt.postgresql.org because it aligns with upstream docker postgresql and makes it easy to extend with other packages (e.g. pgrouting ).
The downside is that PostGIS Debian packages are usually updated more slowly.
Right now, the latest Debian packages I see are still at postgis 3.5.3:
https://www.postgresql.org/search/?m=1&q=postgresql-18-postgis-3&l=76&d=365&s=d

postgresql-18-postgis-3 | 3.5.3+dfsg-1~exp1.pgdg130+1 | trixie-pgdg | amd64, arm64, ppc64el
postgresql-18-postgis-3 | 3.5.3+dfsg-1~exp1.pgdg120+1 | bookworm-pgdg | amd64, arm64, ppc64el

If you’re interested in following the apt.postgresql.org - debian postgis packaging process more closely,
the mailing list is a good resource: https://www.postgresql.org/list/pgsql-pkg-debian/

The Debian experimental package
is interesting, but I think using it would mean losing the easy compatibility and extension ecosystem (pgrouting, mobilitydb, …).

So my preference would be to keep the current conservative approach,
and for Debian-based images only use PostGIS versions available from apt.postgresql.org .

in order to download postgis 3.6rc1?

So we should wait until it appears on apt.postgresql.org (most likely 1–2 weeks after the official 3.6.0 release).


And thanks a lot for updating the images!

When your changes are ready for another review, please let us know.

@thomasboussekey
Copy link
Contributor Author

should the script use this location,
in order to download postgis 3.6rc1?
I'm not an expert of DEBIAN packages 🤣

I’m not an expert either 🙂

Traditionally we use apt.postgresql.org because it aligns with upstream docker postgresql and makes it easy to extend with other packages (e.g. pgrouting ). The downside is that PostGIS Debian packages are usually updated more slowly. Right now, the latest Debian packages I see are still at postgis 3.5.3: https://www.postgresql.org/search/?m=1&q=postgresql-18-postgis-3&l=76&d=365&s=d

postgresql-18-postgis-3 | 3.5.3+dfsg-1~exp1.pgdg130+1 | trixie-pgdg | amd64, arm64, ppc64el
postgresql-18-postgis-3 | 3.5.3+dfsg-1~exp1.pgdg120+1 | bookworm-pgdg | amd64, arm64, ppc64el

If you’re interested in following the apt.postgresql.org - debian postgis packaging process more closely, the mailing list is a good resource: https://www.postgresql.org/list/pgsql-pkg-debian/

The Debian experimental package is interesting, but I think using it would mean losing the easy compatibility and extension ecosystem (pgrouting, mobilitydb, …).

So my preference would be to keep the current conservative approach, and for Debian-based images only use PostGIS versions available from apt.postgresql.org .

in order to download postgis 3.6rc1?

So we should wait until it appears on apt.postgresql.org (most likely 1–2 weeks after the official 3.6.0 release).

And thanks a lot for updating the images!

When your changes are ready for another review, please let us know.

@ImreSamu , it looks good now! I managed to fix Pg18beta3 Dockerfile generation 😅

@ImreSamu
Copy link
Member

@thomasboussekey :

Thank you for this excellent work! The changes are looking really good overall.

I've spotted two minor issues that would be worth addressing:

  1. Directory cleanup needed
    The 17-3.6.0beta1 directory is still present in the repository.
    Ideally, we would have used git mv 17-3.6.0beta1 17-3.6.0rc1 to rename it during the transition, but at this point I think a simple git rm 17-3.6.0beta1 would do the job perfectly.
    Once that's removed, you'll also need to update the README.md since ./update.sh won't include it in the test matrix anymore.

  2. Duplicate entry in workflow
    The .github/workflows/main.yml matrix appears to contain 18beta3-3.5 twice now.
    I believe we can safely remove the duplicate entries from the include: section.

What's working brilliantly:

  • The ./update.sh script is functioning exactly as expected
  • Your pg18 -> trixie solution is really clever; I'm quite impressed with that approach! 💯

These are just small housekeeping items, and the core functionality looks spot on.
Thanks again for your thorough work on this!

@ImreSamu
Copy link
Member

@thomasboussekey ,
Hi, just checking in - if you don’t plan to continue this PR, I’d be happy to pick it up and finish it.

@thomasboussekey
Copy link
Contributor Author

@thomasboussekey , Hi, just checking in - if you don’t plan to continue this PR, I’d be happy to pick it up and finish it.

Hello @ImreSamu ,

I thought that modifications awaited from my side were complete.

If you tell me what should be modified, I can continue on the remaining points.
Else, you can work on this!

@ImreSamu
Copy link
Member

@thomasboussekey ,

I see that both 17-3.6.0* directories are still present:

  • 17-3.6.0beta1 (no longer updated – this one can be removed)
  • 17-3.6.0rc1 (this is the new one).

I suggest also removing the 17-3.6.0beta1 directory and its reference from the README.md, since it won’t be maintained anymore.

If you have time to do this today, that would be great.
If not, no problem - I’ll review everything again carefully after 20:00 UTC
and finish whatever is still missing.

Thanks a lot for your work so far – it’s already a big help!

@ImreSamu ImreSamu requested a review from phillipross August 30, 2025 13:56
@ImreSamu
Copy link
Member

I’ve reviewed and updated this PR, including testing with ./update.sh
I think it’s ready to be merged.
@phillipross, if you have some time, could you also take a look? Thanks!

@thomasboussekey
Copy link
Contributor Author

I’ve reviewed and updated this PR, including testing with ./update.sh I think it’s ready to be merged. @phillipross, if you have some time, could you also take a look? Thanks!

Thank you @ImreSamu , looks good 👍
i'VE DONE a lot of DIY for me this weekend, no remaining time for contributing 😞
Have a great week 😄

- manual update README.md, .github/workflows/main.yml
- change job name in .github/workflows/main.yml
@ImreSamu
Copy link
Member

ImreSamu commented Sep 2, 2025

In the meantime, PostGIS 3.6.0 has been released, so I’ll try to update it.
https://github.com/postgis/postgis/releases/tag/3.6.0

For now, to keep things simple, it will only be added for PG17 and PG18beta3.


The github CI - job names have been improved - the key information now comes first.

new :
image

old:
image

@ImreSamu ImreSamu requested a review from Copilot September 2, 2025 20:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for PostgreSQL 18 beta 3 containers with PostGIS, updating the base Debian suite from bullseye to trixie due to bullseye being outdated. The changes introduce new 18beta3 variants with PostGIS 3.5 and 3.6 support.

  • Adds PostgreSQL 18beta3 support using Debian trixie-slim instead of bullseye-slim
  • Creates new Docker containers for 18beta3 with PostGIS 3.5 and 3.6 versions
  • Updates build configurations and dependency versions for the new PostgreSQL version

Reviewed Changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
update.sh Updates Debian suite mapping to use trixie-slim for PostgreSQL 18 and adds boost version configuration
README.md Updates documentation with new 18beta3 container variants and removes outdated alpha entries
18beta3-3.6/alpine/* Adds PostgreSQL 18beta3 with PostGIS 3.6 Alpine container files
18beta3-3.5/* Adds PostgreSQL 18beta3 with PostGIS 3.5 container files for both Debian and Alpine
17-3.6/alpine/Dockerfile Updates PostGIS from beta1 to stable 3.6.0 release
17-master/Dockerfile Updates git commit hashes for dependencies (SFCGAL, PROJ, GEOS, GDAL, PostGIS)
16-master/Dockerfile Updates git commit hashes for dependencies to match 17-master
.github/workflows/main.yml Adds 18beta3 to CI matrix and updates Docker package version
Comments suppressed due to low confidence (1)

18beta3-3.5/Dockerfile:1

  • This placeholder Dockerfile appears to indicate an issue with the Debian package detection. The comment suggests PostGIS for Debian version 18beta3 is not detected, which may indicate incomplete configuration or missing package availability.
#

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ImreSamu
Copy link
Member

ImreSamu commented Sep 2, 2025

I think it’s ready to be merged.
@phillipross, if you have some time, could you also take a look? Thanks!

Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@thomasboussekey
Copy link
Contributor Author

@ImreSamu @phillipross , tests are OK 🎉

Are there any steps to validate before merging?

@ImreSamu
Copy link
Member

ImreSamu commented Sep 4, 2025

In the meantime, debian’s postgis package has been updated: ( 2025-09-03 07:03:46 )

After re-running the PR CI, it failed: https://github.com/postgis/docker-postgis/actions/runs/17413819763
so I had to fix it.
With the fixes applied, it now seems fine. ✔️

@phillipross , could you take another look? Thanks!

thomasboussekey and others added 3 commits September 5, 2025 05:47
* add trixie inofrmation in the Debian base section
* use bullets in order to improve page rendering
@thomasboussekey
Copy link
Contributor Author

Hello @ImreSamu and @phillipross ,

I've just updated Pg18 to RC1.

When is it possible to get the Pg18RC1 image released, please 🙏 ?
I'd like to test it on cloudnative-pg

@thomasboussekey thomasboussekey changed the title feat: Add pg18beta3 container feat: Add pg18rc1 container, using debian-trixie Sep 8, 2025
@ImreSamu ImreSamu merged commit fc1a773 into postgis:master Sep 8, 2025
31 checks passed
@ImreSamu
Copy link
Member

ImreSamu commented Sep 8, 2025

Hi @thomasboussekey !

Thank you for your contribution!
Unfortunately, this PR cycle took a bit longer than ideal.
I’ll make sure to pay more attention next time so it doesn’t stretch out this long.
Once again, many thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants