- 
                Notifications
    You must be signed in to change notification settings 
- Fork 487
feat: Add pg18rc1 container, using debian-trixie #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
based on trixie as debian-bulleye is getting old
| ( @thomasboussekey ) Thank you for the PR! 1.) 2.) 3.) 
 | 
| 
 Thanks @ImreSamu , fix in progress! For 1️⃣ , it should be named 18beta3-master, no? For 2️⃣ , folder has been renamed For 3️⃣ , for tomorrow 😪 | 
| 
 Yes, correct. 
 Great! | 
| In the meantime, PostGIS 3.6.0rc1 has also been released (2025/08/18): If possible, could you also update: Of course, no problem if you prefer to skip these changes in this PR - I can add them later myself. Thanks in advance! | 
| @ImreSamu should the script use this location, in order to download postgis 3.6rc1? | 
| 
 I’m not an expert either 🙂 Traditionally we use  If you’re interested in following the  The Debian experimental package So my preference would be to keep the current conservative approach, 
 So we should wait until it appears on  And thanks a lot for updating the images! When your changes are ready for another review, please let us know. | 
| 
 @ImreSamu , it looks good now! I managed to fix Pg18beta3 Dockerfile generation 😅 | 
| Thank you for this excellent work! The changes are looking really good overall. I've spotted two minor issues that would be worth addressing: 
 What's working brilliantly: 
 These are just small housekeeping items, and the core functionality looks spot on. | 
| @thomasboussekey , | 
| 
 Hello @ImreSamu , I thought that modifications awaited from my side were complete. If you tell me what should be modified, I can continue on the remaining points. | 
| I see that both 17-3.6.0* directories are still present: 
 I suggest also removing the  If you have time to do this today, that would be great. Thanks a lot for your work so far – it’s already a big help! | 
| I’ve reviewed and updated this PR, including testing with  | 
| 
 Thank you @ImreSamu , looks good 👍 | 
- manual update README.md, .github/workflows/main.yml - change job name in .github/workflows/main.yml
| In the meantime, PostGIS 3.6.0 has been released, so I’ll try to update it. For now, to keep things simple, it will only be added for PG17 and PG18beta3. The github CI - job names have been improved - the key information now comes first. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for PostgreSQL 18 beta 3 containers with PostGIS, updating the base Debian suite from bullseye to trixie due to bullseye being outdated. The changes introduce new 18beta3 variants with PostGIS 3.5 and 3.6 support.
- Adds PostgreSQL 18beta3 support using Debian trixie-slim instead of bullseye-slim
- Creates new Docker containers for 18beta3 with PostGIS 3.5 and 3.6 versions
- Updates build configurations and dependency versions for the new PostgreSQL version
Reviewed Changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description | 
|---|---|
| update.sh | Updates Debian suite mapping to use trixie-slim for PostgreSQL 18 and adds boost version configuration | 
| README.md | Updates documentation with new 18beta3 container variants and removes outdated alpha entries | 
| 18beta3-3.6/alpine/* | Adds PostgreSQL 18beta3 with PostGIS 3.6 Alpine container files | 
| 18beta3-3.5/* | Adds PostgreSQL 18beta3 with PostGIS 3.5 container files for both Debian and Alpine | 
| 17-3.6/alpine/Dockerfile | Updates PostGIS from beta1 to stable 3.6.0 release | 
| 17-master/Dockerfile | Updates git commit hashes for dependencies (SFCGAL, PROJ, GEOS, GDAL, PostGIS) | 
| 16-master/Dockerfile | Updates git commit hashes for dependencies to match 17-master | 
| .github/workflows/main.yml | Adds 18beta3 to CI matrix and updates Docker package version | 
Comments suppressed due to low confidence (1)
18beta3-3.5/Dockerfile:1
- This placeholder Dockerfile appears to indicate an issue with the Debian package detection. The comment suggests PostGIS for Debian version 18beta3 is not detected, which may indicate incomplete configuration or missing package availability.
#
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| I think it’s ready to be merged. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
| @ImreSamu @phillipross , tests are OK 🎉 Are there any steps to validate before merging? | 
| In the meantime, debian’s postgis package has been updated: (  After re-running the PR CI, it failed: https://github.com/postgis/docker-postgis/actions/runs/17413819763 @phillipross , could you take another look? Thanks! | 
* add trixie inofrmation in the Debian base section * use bullets in order to improve page rendering
| Hello @ImreSamu and @phillipross , I've just updated Pg18 to RC1. When is it possible to get the Pg18RC1 image released, please 🙏 ? | 
| Hi @thomasboussekey ! Thank you for your contribution! | 


based on trixie as debian-bulleye is getting old