Skip to content

Added basic-auth path to allow testing with empty password. Fixed #502. #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added basic-auth path to allow testing with empty password. Fixed #502. #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1094016
Added basic-auth path to allow testing with empty password. Fixed #502.
javabrett Aug 15, 2018
3c97d10
Also accept empty username for basic-auth (implies empty password). #…
javabrett Aug 15, 2018
747c11b
basic-auth test improvements:
javabrett Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion httpbin/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,8 +941,10 @@ def delete_cookies():
return r


@app.route("/basic-auth")
@app.route("/basic-auth/<user>")
@app.route("/basic-auth/<user>/<passwd>")
def basic_auth(user="user", passwd="passwd"):
def basic_auth(user="", passwd=""):
"""Prompts the user for authorization using HTTP Basic Auth.
---
tags:
Expand Down
21 changes: 20 additions & 1 deletion test_httpbin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,29 @@ def test_set_cors_headers_after_request(self):
)

def test_set_cors_credentials_headers_after_auth_request(self):
response = self.app.get('/basic-auth/foo/bar')
self._test_set_cors_credentials_headers_after_auth_request('/basic-auth/foo/bar', 'Basic Zm9vOmJhcg==')
self._test_set_cors_credentials_headers_after_auth_request('/basic-auth/foo', 'Basic Zm9vOg==')
self._test_set_cors_credentials_headers_after_auth_request('/basic-auth', 'Basic Og==')

def _test_set_cors_credentials_headers_after_auth_request(self, path, basic_auth):
response = self.app.get(path)
self.assertEqual(
response.headers.get('Access-Control-Allow-Credentials'), 'true'
)
self.assertEqual(
response.headers.get('Www-Authenticate'), 'Basic realm="Fake Realm"'
)
self.assertEqual(
response.status_code, 401
)
response = self.app.get(path, headers={'Authorization': 'Basic BADHASH=='})
self.assertEqual(
response.status_code, 401
)
response = self.app.get(path, headers={'Authorization': basic_auth})
self.assertEqual(
response.status_code, 200
)

def test_set_cors_headers_after_request_with_request_origin(self):
response = self.app.get('/get', headers={'Origin': 'origin'})
Expand Down