Retry-After support #579
Open
Retry-After support #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per RFC 6585 support returning a Retry-After header to test HTTP clients repeating requests. MDN[1] says this can be returned in either an "absolute" format (Retry-After contains a fixed date) or "relative" format (Retry-After contains a number of seconds after which the request may be retried). Both formats are supported in this commit. [1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After
When pushing the Retry-After changes, tox was failing on unit tests that worked on my system running from Pycharm CE. It seems that the reason for this is that the pipenv environment for the repo uses an older version of werkzeug (which in turn relies on an older version of flask). Adding the same fixed versions to tox.ini allows the tox tests to pass on my system so should pass on Travis too.
Improve RFC 6585 compliance
they now make more sense in English: "retry after 60 seconds, returned as a date" "retry after 60 seconds, returned as a number of seconds"
g-a-c
force-pushed
the
feature/retry-after
branch
from
898aa95 to
a8fd89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 6585 support returning a Retry-After header to test HTTP clients repeating requests.
MDN1 says this can be returned in either an "absolute" format (Retry-After contains a fixed date) or "relative" format (Retry-After contains a number of seconds after which the request may be retried). Both formats are supported in this commit.