Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog #657

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Updated changelog #657

wants to merge 2 commits into from

Conversation

oillicker
Copy link
Contributor

This pull request updates the changelog for powercord.
The changelog file is updated to be an array rather than an object so that old changelogs are kept for whatever reason we may want them, and the first one is fetched from the file.
image

Copy link
Contributor

@asportnoy asportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind linking to the issues? It seems unnecessary to me. And if you're going to link to issues, the other 3 fixes should also have links for consistency

changelogs.json Outdated Show resolved Hide resolved
@oillicker
Copy link
Contributor Author

oillicker commented Jun 18, 2022

What's the reasoning behind linking to the issues? It seems unnecessary to me. And if you're going to link to issues, the other 3 fixes should also have links for consistency

Firstly they're pull requests not issues, but I linked the PRs I could find.

Co-authored-by: Albert Portnoy <[email protected]>
@asportnoy
Copy link
Contributor

Still, I don't think there's any point in including them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants