Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two more issues introduced in #343:
populatePersistentChecksumCache
method did not filter according to the group_id (sync rules version) when determining which buckets to update. This was mostly harmless on its own apart from performance overhead, except when combined with the next issue.populatePersistentChecksumCache
, if the bucket_state did not exist already, we created it withlast_op: <compact-checkpoint>
. The issue is this is different from how last_op is usually updated, and violates an unique index when re-using the same last_op across multiple buckets.This resulted in errors such as this:
This could happen either when:
This fixes both issues.