Fix SnapshotTooOld in parameter queries #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c17be72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
approved these changes
Sep 18, 2025
|
From looking at existing instances affected by this, it seems to mostly affect instances running on AWS RDS or self-hosted Postgres, although I have also seen one MySQL and one Supabase instance affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #315 / 1.14.0.
#315 introduced compacting for parameter storage, and switched to using snapshot queries associated with the checkpoint lookups. The snapshots typically give us around 5 minutes from the time we get the checkpoint until the time we do the parameter lokoups.
There is an edge case:
It then uses the same snapshot for the last queried snapshot when doing the parameter queries, resulting in a SnapshotTooOld error:
This fixes it by refreshing the checkpoint once a minute if the checkpoint stream is idle.