-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a non-root base path #34
base: dev
Are you sure you want to change the base?
Conversation
… the scoping of the local graphs
Thought to make the necessary changes more clear
@trwbox Thanks for the pull request! It looks good. Can I know if you have a working demo of a github.io hosted site? It would be helpful in additional to my offline testing. |
I will get one spun up tonight to look at
On Mon, Jun 27, 2022 at 11:48 AM Peter Yuen ***@***.***> wrote:
@trwbox <https://github.com/trwbox> Thanks for the pull request! It looks
good. Can I know if you have a working demo of a github.io hosted site?
It would be helpful in additional to my offline testing.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJYSXDIF24ORJXMUMY3DHG3VRHLPFANCNFSM5ZOWSL5Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Trent R. Walraven
|
I got it created here is a link to the site: A good example page is Antenna on PCB to see the graph, and that in content links work. And here is a link to the github repo: |
The pull request seems reasonable. I would incorporate it in the next release. However, I might not include the |
That makes perfect sense. I added it for consistency sake, but have no issues if it is a part of the readme. I know this might be considered promoting my own project in asking, but if you add that section would you mind linking my Github Pages publishing tool? |
When will this Pull Request be merged? |
This adds an optional BASE_PATH in the configuration file that could be used for something like example.github.io/obsidian-notebook/.
The format has BASE_PATH with no slashes
BASE_PATH = "obsidian-notebook"
, and requires that SITE_URL is changed accordingly, and including a trailing backslash to be likeSITE_URL = https://example.github.io/obsidian-zola/