3.1.0 #557
Merged
3.1.0 #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expanded context structure descriptions for clarity on static, dynamic, and memoized values. - Updated usage patterns to include performance-optimized selective subscriptions for hooks. - Enhanced custom hooks organization with hierarchical composition for better modularity. - Improved component structure section with detailed descriptions of main components and their roles. - Added Google Fonts integration section detailing dynamic loading and configuration options. - Introduced comprehensive internationalization support with new i18n configurations and examples. - Updated common development workflows and best practices for improved clarity and guidance.
…for React Chrono v3.0 - Added new documentation files including API documentation index, quick reference guide, and issue analysis summary. - Created detailed navigation and focus management review to improve accessibility and user experience. - Established next steps for running and fixing Playwright tests, ensuring a smooth testing process. - Updated package.json dependencies and configurations for improved performance and compatibility. - Enhanced CI workflows for better build and testing processes, including Playwright integration. - Introduced a selector map for consistent test element targeting across Playwright tests. - Refactored existing tests to utilize new selectors and improve clarity and maintainability. - Implemented various performance optimizations and accessibility improvements across components.
…ine components - Integrated focus trap and key handler for improved keyboard navigation in PopOver. - Updated PopOver to manage focus more effectively, ensuring compliance with WCAG standards. - Enhanced Timeline components with ARIA attributes for better screen reader support. - Improved focus styles across components for better visibility and user experience. - Added comprehensive tests for new accessibility features and focus management logic.
…er components - Added roving tabindex support to List and ListItem for improved keyboard navigation. - Updated keyboard event handling in ListItem to support Enter and Space for item selection. - Enhanced PopOver to handle item selection via keyboard, closing the popover and restoring focus. - Improved ARIA roles and attributes for better screen reader compatibility across components.
…en by adding stopPropagation to keyboard event handling
…and accessibility - Simplified click handling in List component by removing unnecessary useCallback. - Updated PopOver component to enhance focus management and accessibility, including improved state handling and event listeners. - Refactored search functionality in Timeline components to trigger searches explicitly on Enter key, improving user experience. - Enhanced styling and layout for better responsiveness across components.
… search input - Updated PopOver component to avoid restoring focus to the trigger button when the user is interacting with a search input, improving accessibility and user experience. - Adjusted styling in toolbar components to ensure consistent dimensions for search buttons and icons, enhancing visual coherence across different screen sizes.
…search input - Enhanced focus handling in the Timeline component to avoid stealing focus from the search input during user interactions. - Captured search state at the moment of focus management to prevent timing issues with requestAnimationFrame callbacks. - Updated related hooks to ensure consistent behavior across timeline navigation and search functionalities.
- Deleted the Playwright testing workflow from the GitHub Actions configuration. - This change simplifies the CI setup by removing the now unnecessary Playwright tests workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+15
to
+48
| name: Build & Unit Tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10.15.1 | ||
| - uses: actions/setup-node@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm test -- --run | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Run unit tests (Vitest) | ||
| run: pnpm test -- --run | ||
| env: | ||
| CI: true | ||
| - run: pnpm build | ||
| - uses: actions/upload-artifact@v4 | ||
|
|
||
| - name: Build library | ||
| run: pnpm build | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: dist | ||
| path: dist | ||
| retention-days: 7 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
- Updated various dependencies in package.json and pnpm-lock.yaml for improved performance and security. - Enhanced keyboard navigation in List and Timeline components by implementing roving tabindex for better accessibility. - Improved focus management in PopOver and Timeline components to prevent focus stealing from search inputs. - Added ARIA attributes and roles to enhance screen reader compatibility across components. - Refactored tests to ensure consistent behavior and coverage for new accessibility features.
- Improved focus handling in Timeline and PopOver components to prevent focus stealing from search inputs and ensure better keyboard navigation. - Updated focus restoration logic to only trigger under specific conditions, enhancing user experience during interactions. - Disabled auto-focus for dropdown menus to maintain natural tab order and prevent unexpected focus shifts. - Refactored event handlers in Timeline controls to prevent focus stealing during button interactions, ensuring compliance with accessibility standards.
- Implemented keyboard navigation for ArrowUp and ArrowDown keys in the PopOver component to improve accessibility and user experience. - Wrapped timeline item activation and update callbacks to prevent focus stealing during toolbar navigation, ensuring a smoother interaction flow. - Updated CSS for active timeline items to provide visual feedback without disrupting keyboard focus order. - Refactored focus management logic in Timeline and related components to comply with accessibility standards and enhance usability.
- Replaced useCloseClickOutside with useOutsideClick and useEscapeKey hooks for better separation of concerns in closing the popover. - Enhanced closePopover function to handle focus restoration selectively based on the closing reason (Escape key or click outside). - Updated keyboard event handling for ArrowUp and ArrowDown keys to prevent timeline navigation interference. - Improved comments for clarity on focus restoration logic, ensuring compliance with accessibility standards.
- Updated PopOver component to use an inline function for closePopover, enhancing clarity in event handling. - Refactored Timeline component to ensure text density updates are type-safe by casting to TextDensity. - Simplified event handling in Timeline controls by removing unnecessary parameters from handlePlay and handlePause functions. - Enhanced accessibility in Toolbar by ensuring item IDs are consistently generated, improving focus management.
- Replaced jest.fn() with vi.fn() in keyboard navigation tests for consistency with Vitest. - Enhanced keyboard event handling in useTimelineKeyboardNavigation and useTimelineNavigation tests by adding mock target elements. - Refactored search tests to trigger searches directly, improving clarity and reducing reliance on debounce timing. - Updated CSS styles for timeline card media to ensure consistent class names in snapshots.
- Updated keyboard navigation tests to utilize custom rendering and improved mock implementations for IntersectionObserver and matchMedia. - Refactored timeline component tests to ensure proper rendering and interaction with navigation buttons. - Enhanced accessibility by ensuring ARIA attributes and roles are correctly applied to timeline elements and navigation controls. - Improved focus management during keyboard interactions to prevent focus stealing and ensure a smooth user experience.
- Refactored toolbar tests to enhance accessibility by ensuring buttons are correctly identified by their ARIA labels. - Updated keyboard navigation tests to utilize a mock function for item selection, improving clarity and consistency in event handling. - Enhanced interaction tests to verify that clicking items triggers the expected selection behavior, ensuring a better user experience.
- Removed unnecessary spies and async handling in focus management tests for clarity. - Updated tests to ensure hooks render without errors and handle unmounting gracefully. - Enhanced focus management assertions to verify that hooks are defined and functioning correctly.
- Updated CSS for both horizontal and vertical timeline components to remove the focus ring from the list item containers. - Ensured that the focus ring only appears on the inner card content, improving accessibility and visual clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List components
alternating)
interactions
preferences
Type of Change
How Has This Been Tested?
Screenshots / Screen Recordings (if applicable)
Checklist before requesting a review
AI Tooling Disclosure (Optional)
Additional Context