Skip to content

fix: Improve sorting logic for good first issues and stars #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viral1127 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Improve sorting logic for good first issues and stars #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,16 @@ <h1>Find Great Open Source Opportunities.</h1>
}

function sortByGoodFirstIssues(repos) {

function compare(a, b) {
return returnComp(a.issues.length, b.issues.length, a.starcount, b.starcount)
};


repos.sort(compare);
return repos;
repos.sort((a, b) => {
if (b.issues.length === a.issues.length) {
return b.starcount - a.starcount; // Tie-breaker
}
return b.issues.length - a.issues.length;
});
return repos;
}


function returnComp(a, b, tiebreaker1, tiebreaker2) {


Expand All @@ -341,15 +341,12 @@ <h1>Find Great Open Source Opportunities.</h1>


function sortByStars(repos) {
function compare(a, b) {
return returnComp(a.starcount, b.starcount, a.issues.length, b.issues.length)
};

repos.sort(compare);
return repos;
repos.sort((a, b) => b.starcount - a.starcount);
return repos;
}



function sortBy(value, repositories) {

switch (value) {
Expand Down