Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: identify .td files as tablegen #506

Closed
wants to merge 1 commit into from
Closed

feat: identify .td files as tablegen #506

wants to merge 1 commit into from

Conversation

UtkarshKunwar
Copy link

@UtkarshKunwar UtkarshKunwar commented Feb 9, 2025 •
edited
Loading

Fixes #505.

@asottile
Copy link
Member

asottile commented Feb 9, 2025

I thought I was pretty clear here: #505 (comment)

this is ambiguous

@asottile asottile closed this Feb 9, 2025
@UtkarshKunwar
Copy link
Author

Sorry, I thought *.td was unambiguous as the LLVM project and any derived compiler-related projects use it for TableGen files. In that case, I'll continue using the files regex in pre-commit. Thanks.

@asottile
Copy link
Member

asottile commented Feb 9, 2025

"td file extension" is an easy search away and returns at least 4 different things for me :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TableGen files are not identified
2 participants
@UtkarshKunwar @asottile