Mobkoi Adapter: set integration_type field in bid requests #4080
+68
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeye
force-pushed
the
set-integration-type-field
branch
3 times, most recently
from
d4cc1dc to
a6eeae3
Compare
zeeye
force-pushed
the
set-integration-type-field
branch
3 times, most recently
from
d16f440 to
1901483
Compare
zeeye
force-pushed
the
set-integration-type-field
branch
from
1901483 to
3ff0c54
Compare
CTMBNara
requested changes
Aug 18, 2025
| @Value(staticConstructor = "of") | ||
| public class MobkoiBidRequestExt { | ||
|
|
||
| @JsonProperty("mobkoi") |
There was a problem hiding this comment.
No need for JsonProperty here
| public class MobkoiBidRequestExt { | ||
|
|
||
| @JsonProperty("mobkoi") | ||
| final Mobkoi mobkoi; |
There was a problem hiding this comment.
No need for final modifier, because you are using @Value
| @Value(staticConstructor = "of") | ||
| public static class Mobkoi { | ||
|
|
||
| @JsonProperty("integration_type") |
There was a problem hiding this comment.
No need for @JsonProperty here, our object mapper defaults to snake_case
| public static class Mobkoi { | ||
|
|
||
| @JsonProperty("integration_type") | ||
| final String integrationType = "pbs"; |
|
|
||
| public static MobkoiBidRequestExt of() { | ||
| return new MobkoiBidRequestExt(Mobkoi.of()); | ||
| } |
There was a problem hiding this comment.
Remove this static constructor
@Value(staticConstructor = "of")
public class MobkoiBidRequestExt {
Mobkoi mobkoi = Mobkoi.of();
...
}
Comment on lines
+44
to
+46
| /** | ||
| * The integration endpoint that will be used to send the bid requests to. Managed by the adapter configuration. | ||
| */ |
There was a problem hiding this comment.
No need for this comment
Comment on lines
+12
to
+14
| /** | ||
| * The integration endpoint that the bid requests will be sent to. For example, https://test.mobkoi.com/bid. | ||
| */ |
There was a problem hiding this comment.
No need for this comment
Comment on lines
+259
to
+263
| /** | ||
| * @param placementId The placement id provided by Mobkoi. | ||
| * @param integrationEndpoint The integration endpoint that will be used to send the bid requests to. | ||
| * @return The imp ext. | ||
| */ |
| "description": "Mobkoi's ad server url", | ||
| "pattern": "^https?://[^.]+\\.mobkoi\\.com$" | ||
| "description": "Mobkoi's integration endpoint that will be used to send the bid requests to. For example, https://test.mobkoi.com/bid.", | ||
| "pattern": "^https?://[^.]+\\.mobkoi\\.com(/.*)?$" |
There was a problem hiding this comment.
Rename adServerBaseUrl to integrationEndpoint
|
@zeeye update required |
|
@zeeye any update on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
Set the
ext.mobkoi.integration_typefield of the bid request objects for internal usage.🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check