Nextmillennium: New fields and adapter version update by przemkaczmarek · Pull Request #4246 · prebid/prebid-server-java

przemkaczmarek · 2025-10-18T17:21:42Z

🔧 Type of changes

bid adapter update

✨ What's the context?

AntoxaAntoxic · 2025-10-24T10:22:43Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+                NextMillenniumExtBidder.of(
+                        nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), null, null));


If I understand the changes in Go correctly adslots and allowedads shouldn't be added to the imp.ext

and please, create a separate static constructor of with the only nmmFlags parameter

according to the json's samples:

"mockBidRequest": { "id": "testid", "imp": [ { "id": "123654", "banner": { "w": 320, "h": 250 }, "ext": { "bidder": { "group_id": "7819", "allowedAds":["allowed_ad_1, allowed_ad_2"] } } } ], "app": { "domain": "www.example.com" } }, "httpCalls": [ { "expectedRequest": { "uri": "https://pbs.nextmillmedia.com/openrtb2/auction", "body":{ "id": "testid", "app": { "domain": "www.example.com" }, "ext": { "nextMillennium": { "allowedAds":["allowed_ad_1, allowed_ad_2"], "nm_version":"v1.0.1" }, ``` ---------------------------------------------------------- ``` type nmExtNMM struct { NmmFlags []string `json:"nmmFlags,omitempty"` AdSlots []string `json:"adSlots,omitempty"` AllowedAds []string `json:"allowedAds,omitempty"` ServerVersion string `json:"server_version,omitempty"` AdapterVersion string `json:"nm_version,omitempty"` }

AdSlots and AllowedAds are parts of nmmExt:

it should be included in the ext.nextMillennium, but not in the imp[].ext.nextMillennium (compare the payload you provided and the payload of the integration tests you've added)

@przemkaczmarek ^^

AntoxaAntoxic · 2025-10-24T10:25:35Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+                        nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), NM_ADAPTER_VERSION,
+                        versionProvider.getNameVersionRecord()));


please chop the whole parameter list down

Do you mean listing them one per line or removing them?

one per line, please

AntoxaAntoxic · 2025-10-24T10:28:49Z

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java

                request -> request.app(App.builder().domain("appDomain").build()),
-                givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group1")),
-                givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group2")));
+                givenImpWithExt(identity(), ExtImpNextMillennium.of(null, "group1", null, null)),


I'd prefer extracting ExtImpNextMillennium.of(null, "group1", null, null) and ExtImpNextMillennium.of("placement1", "group1", null, null) into separate methods in order not to pass nulls everywhere

AntoxaAntoxic · 2025-10-24T10:29:32Z

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java

+        final ObjectNode requestExtNode = mapper.valueToTree(actualRequest.getExt());
+        assertThat(requestExtNode.at("/nextMillennium/adSlots/0").asText()).isEqualTo("slot1");
+        assertThat(requestExtNode.at("/nextMillennium/adSlots/1").asText()).isEqualTo("slot2");
+        assertThat(requestExtNode.at("/nextMillennium/allowedAds/0").asText()).isEqualTo("ad1");
+        assertThat(requestExtNode.at("/nextMillennium/allowedAds/1").asText()).isEqualTo("ad2");
+
+        final ObjectNode impExtNode = (ObjectNode) actualRequest.getImp().getFirst().getExt();
+        assertThat(impExtNode.at("/nextMillennium/adSlots/0").asText()).isEqualTo("slot1");
+        assertThat(impExtNode.at("/nextMillennium/adSlots/1").asText()).isEqualTo("slot2");
+        assertThat(impExtNode.at("/nextMillennium/allowedAds/0").asText()).isEqualTo("ad1");
+        assertThat(impExtNode.at("/nextMillennium/allowedAds/1").asText()).isEqualTo("ad2");


I'd prefer using extracting approach like everywhere else in the test

AntoxaAntoxic · 2025-11-07T08:33:55Z

src/main/java/org/prebid/server/bidder/nextmillennium/proto/NextMillenniumExtBidder.java


    String serverVersion;
+
+    public static NextMillenniumExtBidder ofNmmFlags(List<String> nmmFlags) {


AntoxaAntoxic · 2025-11-07T08:34:25Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java


        return bidRequest.toBuilder()
-                .imp(modifyFirstImp(bidRequest.getImp(), soredRequestId, extImp))
+                .imp(modifyFirstImp(bidRequest.getImp(), soredRequestId))


a typo in soredRequestId

AntoxaAntoxic · 2025-11-07T08:34:44Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+                        nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), NM_ADAPTER_VERSION,
+                        versionProvider.getNameVersionRecord()));


Nextmillennium: New fields and adapter version update

29a1efa

AntoxaAntoxic linked an issue Oct 24, 2025 that may be closed by this pull request

Port PR from PBS-Go: Nextmillennium: New fields and adapter version update #4234

Closed

AntoxaAntoxic added the do not port label Oct 24, 2025

AntoxaAntoxic assigned przemkaczmarek Oct 24, 2025

AntoxaAntoxic suggested changes Oct 24, 2025

View reviewed changes

przemkaczmarek added 2 commits October 27, 2025 17:21

fix comments

4824fc4

fix comments

47b9321

osulzhenko requested a review from AntoxaAntoxic November 4, 2025 14:47

przemkaczmarek added 2 commits November 6, 2025 18:16

fix comments

9cfcf4b

fix tests

63a0a43

AntoxaAntoxic suggested changes Nov 7, 2025

View reviewed changes

fix comments

6460856

AntoxaAntoxic approved these changes Nov 14, 2025

View reviewed changes

CTMBNara approved these changes Nov 17, 2025

View reviewed changes

CTMBNara merged commit 4f64c15 into master Nov 17, 2025
7 of 8 checks passed

CTMBNara deleted the Nextmillennium-New-fields-and-adapter-version-update branch November 17, 2025 19:54

		NextMillenniumExtBidder.of(
		nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), null, null));

		nmmFlags, extImp.getAdSlots(), extImp.getAllowedAds(), NM_ADAPTER_VERSION,
		versionProvider.getNameVersionRecord()));


		String serverVersion;

		public static NextMillenniumExtBidder ofNmmFlags(List<String> nmmFlags) {

Conversation

przemkaczmarek commented Oct 18, 2025

🔧 Type of changes

✨ What's the context?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AntoxaAntoxic Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

przemkaczmarek Oct 27, 2025 •

edited

Loading

AntoxaAntoxic Oct 28, 2025 •

edited

Loading