Skip to content

Mobkoi: Always set the TagID with our placementID #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielmougard wants to merge 1 commit into
base: master
Choose a base branch
from
+36 −4
Open

Mobkoi: Always set the TagID with our placementID #4327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/org/prebid/server/bidder/mobkoi/MobkoiBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ private ExtImpMobkoi parseExtImp(Imp imp) {
}

private Imp modifyImp(Imp firstImp, ExtImpMobkoi extImpMobkoi) {
if (StringUtils.isNotBlank(firstImp.getTagid())) {
return firstImp;
}

if (StringUtils.isNotBlank(extImpMobkoi.getPlacementId())) {
return firstImp.toBuilder().tagid(extImpMobkoi.getPlacementId()).build();
}

if (StringUtils.isNotBlank(firstImp.getTagid())) {
return firstImp;
}

throw new PreBidException("invalid because it comes with neither request.imp[0].tagId nor "
+ "req.imp[0].ext.Bidder.placementId");
}
Expand Down
32 changes: 32 additions & 0 deletions src/test/java/org/prebid/server/bidder/mobkoi/MobkoiBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,38 @@ public void makeHttpRequestsShouldAddPlacementIdOnlyInFirstImpressionTagId() {
.containsExactly("pid", null);
}

@Test
public void makeHttpRequestsShouldOverrideExistingTagIdWithPlacementId() {
final ObjectNode mobkoiExt = impExt("placement-id-from-ext");
final Imp givenImp1 = givenImp(impBuilder -> impBuilder.tagid("existing-tag-id").ext(mobkoiExt));
final Imp givenImp2 = givenImp(identity());
final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp1, givenImp2)).build();
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

assertThat(result.getValue())
.extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class))
.flatExtracting(BidRequest::getImp)
.extracting(imp -> imp.getTagid())
.containsExactly("placement-id-from-ext", null);
assertThat(result.getErrors()).isEmpty();
}

@Test
public void makeHttpRequestsShouldKeepExistingTagIdWhenPlacementIdIsMissing() {
final ObjectNode mobkoiExt = impExt(null);
final Imp givenImp1 = givenImp(impBuilder -> impBuilder.tagid("existing-tag-id").ext(mobkoiExt));
final Imp givenImp2 = givenImp(identity());
final BidRequest bidRequest = BidRequest.builder().imp(asList(givenImp1, givenImp2)).build();
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

assertThat(result.getValue())
.extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class))
.flatExtracting(BidRequest::getImp)
.extracting(imp -> imp.getTagid())
.containsExactly("existing-tag-id", null);
assertThat(result.getErrors()).isEmpty();
}

@Test
public void makeHttpRequestsShouldOverrideUserExtAndSetConsent() {
// given
Expand Down