-
Notifications
You must be signed in to change notification settings - Fork 224
Test: Bidder removal fields #4329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marki1an
wants to merge
15
commits into
clean-bidder-request
Choose a base branch
from
functional-tests/remove-redundat-fields-from-bidderrequest
base: clean-bidder-request
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7e4ce74
Update: Remove unnecessary metics checks
marki1an 1233b6c
Update: Add coverage for bidder removal fields
marki1an 5ca717c
Refactor `MediaTypeProcessor`
CTMBNara c32bcc2
Update: Add coverage for bidder removal fields
marki1an e73a6b0
Remove not expected fields from bidder request
CTMBNara 34d4433
Add more coverage for bidder removal fields
marki1an 3b9796c
Replace to false
marki1an 0f62f16
Add units
CTMBNara 7f5f79e
Merge remote-tracking branch 'origin/clean-bidder-request' into funct…
marki1an 1bb910d
Fix bug
CTMBNara ea0c3c0
Update after review
marki1an 1f171a9
Merge remote-tracking branch 'origin/clean-bidder-request' into funct…
marki1an 15cdd97
Update targeting
marki1an f55bd7b
Update after review
marki1an dc3d8e6
Add coverage for `ext?.prebid?.bidAdjustmentFactors?.mediaTypes`
marki1an File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
src/test/groovy/org/prebid/server/functional/model/request/Channel.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.prebid.server.functional.model.request | ||
|
|
||
| import groovy.transform.ToString | ||
| import org.prebid.server.functional.model.ChannelType | ||
|
|
||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| class Channel { | ||
|
|
||
| ChannelType name | ||
| String version | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/AppExt.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/AppExtData.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/AppPrebid.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/BidAdjustmentRule.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/test/groovy/org/prebid/server/functional/model/request/auction/DeviceExt.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/test/groovy/org/prebid/server/functional/model/request/auction/DevicePrebid.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.prebid.server.functional.model.request.auction | ||
|
|
||
| import groovy.transform.EqualsAndHashCode | ||
| import groovy.transform.ToString | ||
|
|
||
| @EqualsAndHashCode | ||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| class DevicePrebid { | ||
|
|
||
| Interstitial interstitial | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/test/groovy/org/prebid/server/functional/model/request/auction/Interstitial.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package org.prebid.server.functional.model.request.auction | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty | ||
| import groovy.transform.EqualsAndHashCode | ||
| import groovy.transform.ToString | ||
|
|
||
| @EqualsAndHashCode | ||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| class Interstitial { | ||
|
|
||
| @JsonProperty("minwidthperc") | ||
| Integer minWidthPercentage | ||
| @JsonProperty("minheightperc") | ||
| Integer minHeightPercentage | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/UserTime.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove