Rubicon: Remove imp.ext.context references #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
SyntaxNode
changed the title
imp.ext.context referencesimp.ext.context references
|
@MaksymTeqBlaze can you please review once conflicts have been resolved? |
MaksymTeqBlaze
previously approved these changes
Dec 11, 2024
MaksymTeqBlaze
dismissed
their stale review
This branch has conflicts that must be resolved
|
@CTMBNara please resolve conflicts |
adapters/rubicon/rubicon.go
Outdated
| return contextData.AdServer.AdSlot | ||
| } else if data.AdServer.Name == "gam" && data.AdServer.AdSlot != "" { | ||
| func extractDfpAdUnitCode(data rubiconData) string { | ||
| if data.AdServer.Name == "gam" && data.AdServer.AdSlot != "" { |
There was a problem hiding this comment.
How about if strings.ToLower(data.AdServer.Name) == "gam" to make sure "GAM" is also a valid Ad Server Name?
Optional: && len(data.AdServer.AdSlot) != 0, it just looks cleaner to me.
Also please sync this branch with the latest PBS main branch.
There was a problem hiding this comment.
"gam": this is exactly how it works in PrebidJava, not sure if case matters but i would prefer to copy java logic
|
@CTMBNara when you get a minute, please resolve conflicts and address the outstanding comment. Thanks! |
bsardo
changed the title
imp.ext.context references
added 2 commits
February 18, 2025 17:58
…ext-references # Conflicts: # adapters/rubicon/rubicon.go
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
bsardo
reviewed
Feb 18, 2025
| "data": { | ||
| "adserver": { | ||
| "name": "gam", | ||
| "adslot": "adSlotFromData" | ||
| } | ||
| "adslot": "adSlotFromContextData" |
There was a problem hiding this comment.
Nitpick: would it be more appropriate if the references to "adSlotFromContextData" in this file were "adSlotFromData"?
| "data": { | ||
| "adserver": { | ||
| "name": "gam", | ||
| "adslot": "adSlotFromData" | ||
| } | ||
| "adslot": "adSlotFromContextData" |
There was a problem hiding this comment.
Nitpick: would it be more appropriate if the references to "adSlotFromContextData" in this file were "adSlotFromData"?
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
VeronikaSolovei9
approved these changes
Feb 19, 2025
bsardo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.