New Adapter: Pixfuture #4117

pixfuture-media · 2024-12-19T15:23:08Z

This Pixfuture Prebid Server Adapter enables seamless integration with Pixfuture's ad exchange, allowing publishers to leverage their demand through server-side header bidding. The adapter formats outgoing bid requests, processes incoming bid responses, and adheres to OpenRTB standards for efficient and privacy-compliant ad delivery.

adapters/pixfuture/pixfuture.go

github-actions · 2024-12-19T15:23:55Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3f33089

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:64:	MakeBids		90.0%
total:									(statements)		91.4%

…t practices and improve clarity

github-actions · 2024-12-19T16:18:26Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 993f157

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:48:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:63:	MakeBids		90.0%
total:									(statements)		91.2%

adapters/pixfuture/pixfuture.go

static/bidder-info/pixfuture.yaml

pixfuture-media · 2024-12-27T14:10:09Z

received

…

On Tue, 24 Dec 2024 at 04:56, Ashish Garg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In static/bidder-info/pixfuture.yaml <#4117 (comment)> : > @@ -0,0 +1,16 @@ +endpoint: "https://srv-adapter.pixfuture.com/pixservices" +maintainer: + email: ***@***.***" Sent an email for verification. Please reply with "received". — Reply to this email directly, view it on GitHub <#4117 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUDNEQT5OAVWPASNEC4GV732HEVTPAVCNFSM6AAAAABT5HIYBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRRG43DAOBRGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

pixfuture-media · 2025-01-07T19:48:45Z

I would like to ask for your help with reviewing a pull request [New Adapter: Pixfuture #4117].
Your feedback would be greatly appreciated.
When do you think you might be able to review this?
Thank you in advance for your time and effort.

github-actions · 2025-01-13T19:50:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 284c847

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:27:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:48:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:63:	MakeBids		90.0%
total:									(statements)		91.2%

bsardo · 2025-01-22T19:28:19Z

@scr-oath can you please review?

pixfuture-media · 2025-01-24T14:49:48Z

@scr-oath can you please review?

Please provide the next steps from our side. We've implemented all the requested changes.

pixfuture-media · 2025-01-28T14:40:52Z

Hi, @gargcreation1992. Please let us know what is required from our end.

bsardo

See my comments. For reference, we have a section in the developer docs that describe how to build and test a Go adapter. LMK if you have any questions.

coverage.out

go.mod

adapters/pixfuture/pixfuture_test.go

adapters/pixfuture/testdata/valid-bid-request.json

config/config.go

static/bidder-info/pixfuture.yaml

adapters/pixfuture/pixfuture.go

Co-authored-by: Sheridan C Rawlins <[email protected]>

github-actions · 2025-01-30T21:45:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ea7d94e

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		70.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:73:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:88:	MakeBids		88.9%
total:									(statements)		82.2%

Co-authored-by: Sheridan C Rawlins <[email protected]>

github-actions · 2025-01-31T16:18:19Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3f13c25

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:83:	MakeBids		88.9%
total:									(statements)		86.0%

scr-oath · 2025-01-31T17:22:19Z

@scr-oath can you please review?

Please provide the next steps from our side. We've implemented all the requested changes.

I still see a bunch of unresolved comments from @bsardo … we can leave the bot-generated comments unresolved, but I would like to re-review after others' comments are addressed (I don't think there's process to promote my RFC to at least neutral… wish there was like an "I approve but defer to others" or the like feature in github - there used to be something like that in gerrit when I used that years and years ago, and I miss it 😉 )

Anyway… will re-review when those are tackled

pixfuture-media · 2025-01-31T17:45:46Z

@scr-oath Apologies for any confusion. I'll review what hasn't been addressed yet and respond to @bsardo accordingly.

github-actions · 2025-01-31T18:50:47Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a407b22

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:83:	MakeBids		88.9%
total:									(statements)		86.0%

go.mod

scr-oath · 2025-02-02T18:46:41Z

@scr-oath Apologies for any confusion. I'll review what hasn't been addressed yet and respond to @bsardo accordingly.

Also, I see one dangling comment from me still #4117 (comment)

I see that you have merged a few times, maybe once more would remove that diff from the go.mod/sum?

github-actions · 2025-02-03T18:42:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3457b8c

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:83:	MakeBids		88.9%
total:									(statements)		86.0%

go.mod

github-actions · 2025-02-04T21:42:04Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f1b859c

pixfuture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:83:	MakeBids		88.9%
total:									(statements)		86.0%

guscarreon · 2025-02-11T19:57:00Z

go.mod

@@ -84,4 +84,4 @@ require (
 	google.golang.org/protobuf v1.33.0 // indirect
 	gopkg.in/ini.v1 v1.66.4 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
-)
+)


This file seems to have slight, inconsequential format change with respect to master. Can you bring master's version so we don't have this change listed here?

$ git checkout --patch master go.mod

guscarreon · 2025-02-11T19:57:23Z

go.sum

@@ -1018,4 +1018,4 @@ honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9
 honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
 rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
 rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
-rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
+rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=


This file seems to have slight, inconsequential format change with respect to master. Can you bring master's version so we don't have this change listed here?

$ git checkout --patch master go.sum

guscarreon · 2025-02-11T19:58:18Z

coverage.out

+github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:90.35,92.18 2 1
+github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:92.18,94.13 2 0
+github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:96.4,99.6 1 1
+github.com/prebid/prebid-server/v3/adapters/pixfuture/pixfuture.go:103.2,103.28 1 1


There's no need to incorporate this file into our repository. Can you please delete coverage.out?

pixfuture-media and others added 12 commits December 5, 2024 19:43

added initila Pixfuture adapter files and codesd

93e6573

Miodified vendors timewait

458fad1

Adding test file

d67a079

Added prams_test.go

a9fe81b

Changing pix endpoint to srv-adapter.pixfuture.com

606b185

Made changes in test.go

061b818

Addede changes to pixfuture_test.go

d0bc2e1

Merge branch 'prebid:master' into master

eec17ff

update coverage.out

cb8e3a7

added doc

bba6eed

fixing bags

22df0f8

Merge branch 'prebid:master' into master

3f33089

github-actions bot reviewed Dec 19, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 19, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

pixfuture-media added 2 commits December 19, 2024 16:10

Fixed naming convention issue for Pixfuture adapter to align with bes…

a22b19e

…t practices and improve clarity

Merge branch 'master' of github.com:pixfuture-media/prebid-server

993f157

gargcreation1992 self-assigned this Dec 24, 2024

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

adapters/pixfuture/pixfuture.go Show resolved Hide resolved

gargcreation1992 reviewed Dec 24, 2024

View reviewed changes

static/bidder-info/pixfuture.yaml Show resolved Hide resolved

bsardo changed the title ~~New Pixfuture adapter~~ New Adapter: Pixfuture Jan 6, 2025

bsardo added the adapter label Jan 6, 2025

pixfuture-media requested a review from gargcreation1992 January 6, 2025 18:56

Merge branch 'prebid:master' into master

284c847

Made changes regarding github-actions

9e470a0

bsardo reviewed Jan 29, 2025

View reviewed changes

scr-oath suggested changes Jan 30, 2025

View reviewed changes

Update adapters/pixfuture/pixfuture.go

ea7d94e

Co-authored-by: Sheridan C Rawlins <[email protected]>

pixfuture-media and others added 8 commits January 30, 2025 16:48

Update adapters/pixfuture/pixfuture.go

8dac147

Co-authored-by: Sheridan C Rawlins <[email protected]>

Update adapters/pixfuture/pixfuture.go

078c276

Co-authored-by: Sheridan C Rawlins <[email protected]>

Update adapters/pixfuture/pixfuture.go

0b62c21

Co-authored-by: Sheridan C Rawlins <[email protected]>

Made changes in Pixfuture.go

7bdabf4

Made changes regarding GitHub reviews

3f219c9

Made changes regarding GitHub reviews

bb9b65d

Made changes regarding GitHub reviews

7a3352f

Made changes regarding GitHub reviews

3f13c25

Made changes regarding GitHub reviews

a407b22

scr-oath reviewed Jan 31, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Made changes regarding GitHub reviews

3457b8c

scr-oath suggested changes Feb 4, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Merge branch 'prebid:master' into master

f1b859c

bsardo assigned guscarreon and unassigned gargcreation1992 Feb 5, 2025

guscarreon reviewed Feb 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: Pixfuture #4117

New Adapter: Pixfuture #4117

pixfuture-media commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

pixfuture-media commented Dec 27, 2024 via email

pixfuture-media commented Jan 7, 2025

github-actions bot commented Jan 13, 2025

bsardo commented Jan 22, 2025

pixfuture-media commented Jan 24, 2025

pixfuture-media commented Jan 28, 2025

bsardo left a comment

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 31, 2025

scr-oath commented Jan 31, 2025

pixfuture-media commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

scr-oath commented Feb 2, 2025

github-actions bot commented Feb 3, 2025

github-actions bot commented Feb 4, 2025

guscarreon Feb 11, 2025

guscarreon Feb 11, 2025

guscarreon Feb 11, 2025

New Adapter: Pixfuture #4117

Are you sure you want to change the base?

New Adapter: Pixfuture #4117

Conversation

pixfuture-media commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

Code coverage summary

pixfuture

github-actions bot commented Dec 19, 2024

Code coverage summary

pixfuture

pixfuture-media commented Dec 27, 2024 via email

pixfuture-media commented Jan 7, 2025

github-actions bot commented Jan 13, 2025

Code coverage summary

pixfuture

bsardo commented Jan 22, 2025

pixfuture-media commented Jan 24, 2025

pixfuture-media commented Jan 28, 2025

bsardo left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2025

Code coverage summary

pixfuture

github-actions bot commented Jan 31, 2025

Code coverage summary

pixfuture

scr-oath commented Jan 31, 2025

pixfuture-media commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

Code coverage summary

pixfuture

scr-oath commented Feb 2, 2025

github-actions bot commented Feb 3, 2025

Code coverage summary

pixfuture

github-actions bot commented Feb 4, 2025

Code coverage summary

pixfuture

guscarreon Feb 11, 2025

Choose a reason for hiding this comment

guscarreon Feb 11, 2025

Choose a reason for hiding this comment

guscarreon Feb 11, 2025

Choose a reason for hiding this comment