Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic: Set bid.meta.mediaType=video when bid.ext.ibv=true #4189

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Pubmatic: Set bid.meta.mediaType=video when bid.ext.ibv=true #4189

wants to merge 5 commits into from

Conversation

pm-priyanka-bagade
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 57cb1d2

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.5%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:523:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:545:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:557:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:570:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:585:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:635:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:648:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:670:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:679:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 96bff22

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				91.5%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:523:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:545:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:557:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:570:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:585:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:635:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:648:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:670:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:679:	getDisplayManagerAndVer			100.0%
total:									(statements)				93.5%

@bsardo bsardo added the adapter label Feb 3, 2025
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e1f0fbe

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 446ec4a

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5aa750e

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:86:	MakeRequests				93.8%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:196:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:239:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:247:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:255:	parseImpressionObject			92.2%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:352:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:403:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:421:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:435:	MakeBids				88.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:528:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:550:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:562:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:575:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:590:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:640:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:653:	getMediaTypeForBid			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:676:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:685:	getDisplayManagerAndVer			100.0%
total:									(statements)				92.9%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-isha-bharti pm-isha-bharti pm-isha-bharti left review comments

@pm-jaydeep-mohite pm-jaydeep-mohite pm-jaydeep-mohite left review comments

@pm-saurabh-narkhede pm-saurabh-narkhede pm-saurabh-narkhede left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pm-priyanka-bagade @pm-isha-bharti @pm-jaydeep-mohite @pm-saurabh-narkhede @bsardo