Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-renderer integration example #5859

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Conversation

hogekai
Copy link
Contributor

@hogekai hogekai commented Feb 5, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 0f48b17
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67b59f01d9ff7400081ab51b
😎 Deploy Preview https://deploy-preview-5859--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It works! Amazing 🥳

@muuki88 muuki88 added LGTM Needs second review If somebody else should look at the change labels Feb 6, 2025
## Example

{% capture htmlCodePrebid %}
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution

googletag.display('div-banner-native');
});
{% capture htmlCodePrebid %}
<script src="https://cdn.michao-ssp.com/original/prebid.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this PR open until prebid/Prebid.js#12507 is merged and it can be replaced with "not-for-prod" distribution, so you don't have to maintain this distribution

@muuki88 muuki88 merged commit 81869ae into prebid:master Feb 19, 2025
5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Feb 19, 2025

Awesome 🎉 Thanks for your time and resources spend on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Needs second review If somebody else should look at the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants