Conversation
Covers: - Formatting the precice-config.xml - Checking the Markdown files - Checking shell scripts with shellcheck
Add a pre-commit hook
ivan-pi
reviewed
Mar 22, 2024
Co-authored-by: Ivan Pribec <ivan.pribec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
.f03to.f90, which is generally assumed to be a good practice. (Change file extension of Fortran source files to .f90 #17)Various under-the hood fixes:
.gitignorefile. (Solverdummy clean.sh and .gitignore #21)@IshaanDesai could you please do a sanity check in the diff and see if you spot any show-stoppers?
The only PR that could be interesting integrating already is #26 (dropping all the size arguments from next to the strings). However, it is not necessary to wait for it, as that would only be an enhancement.
I would then tag this as v3.0.0.0, similar to other bindings.