Extend docs on compositional coupling with deadlock example#498
Conversation
carme-hp
left a comment
There was a problem hiding this comment.
I think that the explanation for the deadlock and its solution is clear:)
Not difficult. But wouldn't it be neater to see an actual config visualization? You mentioned that you have a minimal example, right? |
|
This error can only occur with serial coupling schemes? And is it possible to occur with two or more participants? |
Co-authored-by: carme-hp <71499004+carme-hp@users.noreply.github.com>
https://github.com/precice/precice/blob/develop/tests/serial/circular/Explicit.xml and swap participants in line 65. In the config visualization the coupling scheme is separated from the exchanges, right? |
yes
You need at least three participant to get such a circular dependency. For two participants, you can only define one coupling scheme. |
| ```mermaid | ||
| graph LR; | ||
| A -- first to second --> B; | ||
| B -- first to second --> C; | ||
| C -- first to second --> A; | ||
| ``` |
|
Merging here. Let's add the mermaid graph eventually, see #552 |
I promised in precice/precice#1907 to add a docs section on deadlocks in compositional coupling. I tried to add the simplest possible example.
The mermaid graph will probably not work on the website. Would this be easy to add? If not, I would add the comment in a comment and add the svg instead.
graph LR; A -- first to second --> B; B -- first to second --> C; C -- first to second --> A;@fsimonis @carme-hp Enough information covered and would you prefer to see more examples and problems?
@orlandoisepic Could be a potential case for the checker a well.