Skip to content

Comments

Remove unused jquery.cookie dependency and add no-cookies notice to f…#735

Open
Wdhanashri wants to merge 2 commits intoprecice:masterfrom
Wdhanashri:fix/remove-cookie-dependency-49
Open

Remove unused jquery.cookie dependency and add no-cookies notice to f…#735
Wdhanashri wants to merge 2 commits intoprecice:masterfrom
Wdhanashri:fix/remove-cookie-dependency-49

Conversation

@Wdhanashri
Copy link
Contributor

The jquery.cookie library was loaded but never used Added a privacy notice to the footer confirming the site does not use cookies or tracking. Addresses #49

…ooter

The jquery.cookie library was loaded but never used
Added a privacy notice to the footer confirming the site does not use cookies or tracking.
Addresses precice#49
@Wdhanashri Wdhanashri mentioned this pull request Feb 22, 2026
@MakisH
Copy link
Member

MakisH commented Feb 22, 2026

@Wdhanashri thanks! How did you confirm that no cookies are set? We should be rather sure before adding such a notice.

What happens in pages where we embed from YouTube, for example? Here is one: https://precice.org/community-contribute-to-precice.html

@Wdhanashri
Copy link
Contributor Author

@MakisH I verified by auditing the codebase:

  • Removed the unused jquery.cookie library (loaded but never called)
  • Plausible Analytics is cookieless by design
  • Algolia search does not set cookies unless we explicitly enable useCookie: true in search-insights, current preCICE site doesn't use search-insights.
  • YouTube embeds already use youtube-nocookie.com (privacy-enhanced mode), which avoids cookies until a user clicks play

The only edge case is YouTube after playback — if we want to be fully accurate, we could soften the notice to "No first-party cookies" or "No cookies on this page" on pages without embeds.

Happy to adjust the wording.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused jquery.cookie dependency from the site header and adds a privacy notice to the footer stating that the site does not use cookies or tracking (Issue #49).

Changes:

  • Removed the jquery.cookie CDN script include from _includes/head.html.
  • Added a “No cookies. No tracking.” notice with an icon to _includes/footer.html.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
_includes/head.html Removes the unused jquery.cookie script include from the global page header.
_includes/footer.html Adds a privacy/cookie notice to the site footer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MakisH
Copy link
Member

MakisH commented Feb 22, 2026

@Wdhanashri again: consider Copilot for what it is and address what you feel makes sense. I just wanted some help in reviewing.

Adjusted footer text to "This website does not use cookies"
@MakisH
Copy link
Member

MakisH commented Feb 22, 2026

Thanks for all the updates! The footer currently looks like this (looks a bit of an outlier, but still):

Screenshot from 2026-02-22 22-55-45

I am leaving this open until I get a second opinion.

@chlorenz since you briefly looked at this at some point, what do you think? (I hope you read here)

@fsimonis fsimonis self-requested a review February 23, 2026 12:56
@fsimonis
Copy link
Member

According to Firefox Dev Tools, it looks like the new mailercloud newsletter uses a challenge from challenges.cloudflare.com, which adds a cookie.

We could just add a subscribe button and link to the standalone webform instead. What do you think @MakisH

@MakisH
Copy link
Member

MakisH commented Feb 23, 2026

We could just add a subscribe button and link to the standalone webform instead. What do you think @MakisH

I agree. This would also make the page lighter.

@precice-bot
Copy link
Contributor

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/gsoc-2026-dhanashri-wankhade/2754/1

@MakisH MakisH added GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website labels Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants