Skip to content

Comments

fix(ui): use exact https protocol for DataTables CDN#770

Merged
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/datatables-protocol-relative-urls
Feb 23, 2026
Merged

fix(ui): use exact https protocol for DataTables CDN#770
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/datatables-protocol-relative-urls

Conversation

@praaatap
Copy link
Contributor

Description

This PR replaces the deprecated protocol-relative URLs (//cdn.datatables.net/...) with explicit https:// URLs in _layouts/default.html.

Protocol-relative URLs are no longer recommended as best practice. Using explicit https:// improves security, aligns with modern standards, and prevents issues when running the site locally.

This is a minimal 2-line change.

Fixes #769

@MakisH MakisH requested a review from Copilot February 23, 2026 12:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DataTables CDN asset URLs in the default Jekyll layout to use explicit https:// instead of protocol-relative URLs, addressing the security/UX concern raised in #769.

Changes:

  • Replaced protocol-relative DataTables CSS URL with an explicit https:// URL.
  • Replaced protocol-relative DataTables JS URL with an explicit https:// URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we use https everywhere else anyway.

Also for this one: no parent issue needed for such small and clear fixes.

@MakisH MakisH merged commit 97423e0 into precice:master Feb 23, 2026
2 checks passed
@MakisH MakisH added GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website labels Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Security/UX: Replace protocol-relative URLs with explicit HTTPS for DataTables CDN

2 participants