Merged
Conversation
MakisH
approved these changes
Feb 23, 2026
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thanks! Does not have any effect, since we don't use Google Analytics, but this looked anyway wrong.
Member
There was a problem hiding this comment.
I would avoid touching the formatting in unrelated files, as this might introduce unnecessary conflicts. In any case, this is only one file in this PR, and the formatting changes make sense, so that's fine.
MakisH
changed the title
MakisH
added
GSoC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes invalid HTML structure in _layouts/default.html and _layouts/landing_page.html.
Previously, the google_analytics.html include block was placed after the closing
</body>tag (between</body>and</html>). This is invalid HTML, as all visible and functional blocks (like analytics scripts) must be contained within the<body>or<head>tags.This PR moves the block directly above the closing
</body>tag to ensure the output is valid HTML and conforms to standard web best practices.Fixes
Fixes #<ISSUE_NUMBER_HERE>
(If you did not make an issue for this, you can just delete this line).