Skip to content

Use pkg-config to determine flags #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Use pkg-config to determine flags #135

wants to merge 8 commits into from

Conversation

BenjaminRodenberg
Copy link
Member

Closes #5.

@fsimonis: One thing I'm worrying a bit: What if a user does not have pkg-config installed? Or would you just take this as granted?

@BenjaminRodenberg BenjaminRodenberg added the enhancement New feature or request label Oct 21, 2021
@BenjaminRodenberg BenjaminRodenberg self-assigned this Oct 21, 2021
@BenjaminRodenberg
Copy link
Member Author

It looks like the "user" precice/precice is already causing trouble here. Locally everything worked nicely.

@fsimonis
Copy link
Member

One thing I'm worrying a bit: What if a user does not have pkg-config installed? Or would you just take this as granted?

I would not take this for granted, but it is available everywhere (even on Windows).
There should be no issue requiring this.

Also, keep in mind that the majority of our adapters rely on pkg-config.

@fsimonis
Copy link
Member

@BenjaminRodenberg FYI, the pkg-config package is not installed in the current precice/precice:latest (25.10 16:15).

@ajaust
Copy link
Collaborator

ajaust commented Mar 29, 2022

I vote for obtaining the include and link flags for preCICE. Otherwise, it seems to be pretty hard/impossible to build the bindings on MacOS. According to some blog posts LD_LIBRARY_PATH and DYLD_LIBRARY_PATH are not forwarded to subprocesses anymore due to the security measure in MacOS X. Obtaining the necessary flags seems to help. This is also connected to #139.

However, this still leaves us with the problem of using the Python bindings on MacOS X. We could try set the rpath for the bindings, but then the bindings get (less) portable. I am not sure if that would be a problem.

Is there any opinion on how well or whether to support MacOS x?

@ajaust
Copy link
Collaborator

ajaust commented Mar 29, 2022

And another note... If we want to use pkg-config we could also think about using the pkgconfig package available in Python which would maybe make the setup files look a bit nicer.

@IshaanDesai
Copy link
Member

The python package pkgconfig is now used to determine preCICE flags in the bindings. This was implemented in #149

@IshaanDesai IshaanDesai deleted the i_5 branch March 21, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pkg-config to detect flags
4 participants