-
-
Notifications
You must be signed in to change notification settings - Fork 16
Release v2.5.0.0 #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v2.5.0.0 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add checksum of v2.4.0.0 * Changes to package.py as recommended by Spack devs * Remove unnecessary preCICE dependency line * Fix import statement and update outdated copyright header * Correct lower bound of bindings version in the preCICE dependency line * Change lib. folder to lib in spack execution command in the build_spack workflow * Trying out lib/ * Revert pip dependency lower bound * Reverting version in preCICE dependency to 2.4.0.1 * Revert to adding the when condition to packaging and pip dependencies * Correct package version in depends_on command * Correct bindings version ranges in command for preCICE * Removing all trial changes and reverting package.py to what it is in the Spack repo * Try to upload spack build log file as artifact * Segregating building and testing in build_spack workflow * Update Dockerfile for Spack build and test to Ubuntu 20.04 * Reverting build-spack.yml to its original state * Use Ubuntu 20.04 container * Install and load py-pyprecice package before testing it in the build_spack workflow * Simplifying the build-spack Action * Furhter simplifying workflow * Updating ci-spack-pyprecice-deps container to Ubuntu 22.04 * Update to Ubuntu 22.04 image in build-env * Finally build_spack works
…o link to preCICE (#149) * Assign value to _value in read_scalar_data function to avoid compiler Warning * Run cmake in setup test action and copy over Version.h file to dummy preCICE folder * Install Boost in build-and-test action so that cmake can find it * Install Eigen via apt so that cmake finds it * Correcting path to dummy preCICE directory in build and test action * Use pkgconfig to detect library flag needed for Version.h in build and test action * Install pkg-config via apt-get in the build and test action * Add pkgconfig include flags to setup.py * Spelling mistake * Check if pkg-config finds precice * Check if pkg-config finds libprecice * Specifically use container precice/precice:2.4.0 * Add pkgconfig command to testing part of setup.py * Check version of libprecice detected by pkg-config in setup_test workflow * Check if PKG_CONFIG_PATH is set in the build_test workflow * Set PKG_CONFIG_PATH in the correct step * Check if pk-config finds libprecice * Add cflags to compile arguments in setup.py * Add PKG_CONFIG_SYSTEM_INCLUDE_PATH env to build and test workflow * Split cflags from pkgconfig before appending them to compile_args in setup.py * Strip double quotes from cflags * Change how pkgconfig cflags are added to compile_args in setup.py * Build pkg-config in all workflows of build and test * Add pkg-config installation to run-solverdummy workflow * Remove :2.4.0 version tag from setup_install workflow to see what happens * Removing 2.4.0 version tag from all workflows
BenjaminRodenberg
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release for preCICE v2.5.0
Main features: