Conversation
… in visualize_partitioned_domain.py. Wrap boundary conditions in new class BoundaryWrapper because they are dependent on the solver iterations. Implement implicit Euler (and Jacobian and residual for the root finding iteration. Initialize participants. Zero gradient condition on the outside boundaries.
…-surrogate.sh, generate-training-data.sh. Fix floating point issue in t_index. Add --savefile argument to solver-scipy-fvolumes.py to save data for training.
…n scripts. Fix requirements.txt for scipy and surrogate solvers. Add example images for README
…ipt to check for initial conditions after installing environment.
uekerman
left a comment
There was a problem hiding this comment.
Thanks for the very nice addition already! I only had brief look in this first iteration and did not yet try to run things. Please see comments below.
Let's indeed remove the Nutils solver. Could always be added later again.
…arate from images directory.
… versions in requirements. Remove commented out code from solvers.
uekerman
left a comment
There was a problem hiding this comment.
I was able to run the cases and got meaningful results. We are probably close to merging this. Mainly cosmetics now.
I think a few scripts of utils could go into solver-scipy. Only keep those in utils that are used by neumann-surrogate as well.
partitioned-burgers-1d/README.md
Outdated
| ## Visualization | ||
|
|
||
| After both participants (and/or monolithic simulation) have finished, you can run the visualization script. | ||
| `visualize_partitioned_domain.py` generates plots comparing the partitioned and monolithic solutions. You can specify which timestep to plot: |
There was a problem hiding this comment.
How can I compare partitioned and monolithic solutions? If I just run it after one setup, I only get that one setup.
There was a problem hiding this comment.
Yes. You have to run both the partitioned and monolithic cases first. The visualize script will draw the monolithic solution conditionally if it exists. For this reason I have the helper scripts to run everything with one command.
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@ipvs.uni-stuttgart.de>
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@ipvs.uni-stuttgart.de>
…ll silence the warning messages.
… uncommenting one line. Relax pyprecice version requirements.
…he other data exchange?
…tion to Post-processing. Remove unused initial-condition.png
New tutorial case: Partitioned Burgers' Equation in 1D solved with SciPy Finite Volume implementation and a Neural Network surrogate model !
Checklist:
changelog-entries/<PRnumber>.md.