Conversation
When a build backend produces host or build dependencies as binary matchspec requirements (such as r-statforbiology * from an R DESCRIPTION or Python pyproject.toml), nested solves previously had no visibility into workspace-level source declarations and attempted to solve these dependencies as binary packages from remote Conda channels. This change propagates workspace_sources across SolvePixiEnvironmentSpec, ResolveSourcePackageSpec, assemble_source_record, and nested_solve. In nested_solve, binary requirements whose package name matches an entry in workspace_sources are mapped into source specifications while preserving version and build constraints from the backend matchspec. In addition, walk_and_resolve falls back to workspace_sources during dependency traversal. Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a build backend produces host or build dependencies as binary matchspec requirements (such as
r-statforbiology *from an RDESCRIPTIONfile or a Pythonpyproject.toml), nested solves previously had no visibility into workspace-level source declarations and attempted to solve these dependencies as binary packages from remote Conda channels. If the package was only available from Git or a local path declared in the workspace, the solve failed with "No candidates were found".This PR:
workspace_sourcesthroughSolvePixiEnvironmentSpec,ResolveSourcePackageSpec,assemble_source_record, andnested_solve.nested_solve, checks if any required package name matches an entry inworkspace_sources, resolving it as a source package while preserving the backend's version constraints.walk_and_resolvefalls back toworkspace_sourceswhen traversing nested dependencies.Fixes #6925
How Has This Been Tested?
test_nested_source_dependency_resolved_from_workspaceincrates/pixi_command_dispatcher/tests/integration/main.rs:cargo test -p pixi_command_dispatcher(174 unit tests, 44 integration tests passed).AI Disclosure
Tools: Claude
Checklist: