Conversation
Reject `channel` in package runtime dependency tables ([package.run-dependencies], [package.run-constraints], [package.extra-dependencies], and [package.run-exports]). Conda packages cannot specify channels for downstream consumers; channels must be configured at the workspace or environment level. Top-level environment solves ignore channel qualifiers in package records, giving package authors a false impression that provenance is constrained. Closes prefix-dev#6747. Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
pixi.toml, package authors could previously specifychannelin runtime dependency tables ([package.run-dependencies],[package.run-constraints],[package.extra-dependencies], and[package.run-exports]). However, a built package cannot constrain or add channels to consuming environments; channels are resolved at the workspace/environment level, and top-level environment solves ignore channel qualifiers in package records. This gave package authors a false impression that dependency provenance was constrained.This PR:
channelin[package.run-dependencies],[package.run-constraints],[package.extra-dependencies], and[package.run-exports]with clear spans and helpful error diagnostics.channelin[package.host-dependencies]and[package.build-dependencies](where build-time environments can respect them).Fixes #6747
How Has This Been Tested?
crates/pixi_manifest/src/toml/package_target.rs:test_channel_in_run_dependencies_is_rejectedtest_channel_in_run_constraints_is_rejectedtest_channel_in_extra_dependencies_is_rejectedtest_channel_in_host_and_build_dependencies_is_allowedcargo test -p pixi_manifest package_target(all 13 tests passed).AI Disclosure
Tools: Claude
Checklist: